Skip to content

Commit d6a6e21

Browse files
committed
Formalize the changes.
1 parent 6283883 commit d6a6e21

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

.github/workflows/RunTests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ jobs:
7575
device_name: v4-8
7676
pytest_marker: 'not gpu_only and not integration_test'
7777
test_directory: 'tests'
78-
# xla_python_client_mem_fraction: 0.75
79-
# tf_force_gpu_allow_growth: false
80-
# container_resource_option: "--privileged"
8178

8279
tpu_integration_tests:
8380
needs: tpu_image

MaxText/tests/train_tests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,6 @@ def test_tpu_dropout(self):
166166
def test_gpu_dropout(self):
167167
train_main(TrainTests.CONFIGS["dropout"] + ["attention=dot_product"])
168168

169-
# # TODO (b/393393501) : MaxText build failure in hf_data_processing_test.py
170-
# @pytest.mark.skip(reason="Tests are currently flaking / failing due to HF token issues")
171169
@pytest.mark.tpu_only
172170
def test_tpu_hf_input_pipeline(self):
173171
train_main(TrainTests.CONFIGS["hf_input_pipeline"])

docker_run_pathways_containers.sh

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,14 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# Example - bash docker_run_pathways_containers.sh maxtext_image=us-docker.pkg.dev/cloud-tpu-v2-images-dev/pathways/maxtext_jax_stable:latest command="cd MaxText ; python3 -m pytest tests -m 'not gpu_only and not integration_test' -s"
18-
19-
# Stop execution if any command exits with error
20-
17+
# Examples -
18+
# TPU unit tests - bash docker_run_pathways_containers.sh maxtext_image=us-docker.pkg.dev/cloud-tpu-v2-images-dev/pathways/maxtext_jax_stable:latest command="cd MaxText ; python3 -m pytest tests -m 'not gpu_only and not integration_test' -s"
2119

2220
echo "Running docker_run_pathways_containers.sh"
2321

22+
# Stop execution if any command exits with error
2423
set -e
2524

26-
# Defaults -
27-
maxtext_image=us-docker.pkg.dev/cloud-tpu-v2-images-dev/pathways/maxtext_jax_stable:latest
28-
command="cd MaxText ; python3 -m pytest tests -m 'not gpu_only and not integration_test' -s"
2925

3026
# Parse input variables
3127
for ARGUMENT in "$@"; do

0 commit comments

Comments
 (0)