Skip to content

Remove / Fork @jsdevtools/ono #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BonaFideIT0 opened this issue Jun 3, 2025 · 2 comments
Closed

Remove / Fork @jsdevtools/ono #386

BonaFideIT0 opened this issue Jun 3, 2025 · 2 comments

Comments

@BonaFideIT0
Copy link

Jsdevtools/ono contains a bug which crashes the client if the package is build without commonjs. So any esm built fails as this broken code is included in the esm version. Anything rollup based that uses this cant build or use OAS because of this dependency.

There is an open issue as well as a "fixing" pull request:

The developer @JamesMessinger has not reacted to multiple mentions for more than a year, the bug will be two years old soon.

I suggest forking and fixing the package, and including the fork as a dependency, or moving to remove the dependency from this package completely to fix the oas library.

@jonluca
Copy link
Collaborator

jonluca commented Jun 3, 2025

Done, 3902889

Release v13.0.0 with this change, as a major version release in case people were depending on the stack traces from ono.

https://github.com/APIDevTools/json-schema-ref-parser/releases/tag/v13.0.0

@jonluca jonluca closed this as completed Jun 3, 2025
@BonaFideIT0
Copy link
Author

awesome, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants