Skip to content
This repository was archived by the owner on Sep 13, 2024. It is now read-only.
This repository was archived by the owner on Sep 13, 2024. It is now read-only.

OS detection fails in packaged/production builds, causing undefined instead of menu icons #244

@mikeseese

Description

@mikeseese

Problem Description

After packaging my Electron app for production, the min/max/close buttons show as undefined due to

Steps to Reproduce

  1. Integrate custom-electron-titlebar into https://github.com/electron-react-boilerplate/electron-react-boilerplate
  2. Run npm run package
  3. Run the installer in the release/build directory
  4. Installed app should have the noticed issues

Expected Behavior

The icons should display correctly.

Current Behavior

image

Additional Information

This is running on Windows 11.

Tentative Solution Steps

This seems to be due to incorrect OS detection in src/base/common/platform.ts. I was able to resolve this issue myself with this commit: Incanta@ba16f79

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions