Skip to content

[2.0.0-dev] replace all legacy keys from docs, tests, tutorials, etc with their canonical form #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/2.0
Choose a base branch
from
Open

[2.0.0-dev] replace all legacy keys from docs, tests, tutorials, etc with their canonical form #1602

wants to merge 1 commit into from

Conversation

spoonincode
Copy link
Member

Tests in test_cypher_suites.cpp and cli_test.py retain legacy keys as needed for testing legacy keys.

I guess we will have to be mindful on merges from main that we don't reintroduce legacy keys; we'll probably just have to make another pass closer to 2.0 release

Base automatically changed from PUBK1_20 to release/2.0 June 23, 2025 21:46
@spoonincode
Copy link
Member Author

thanks for the approvals; I really want to remove accounts.json before it becomes part of the main branch history. I don't see any reason we can't just generate all those on the fly. So I'm going to hold on this a little until I can find some time to try and remove the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spoonincode @greg7mdp @heifner