Move polar plot to Python_Toolkit #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Kingstone
added
type:feature
|
@Tom-Kingstone just to let you know, I have provided a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on BHoM/Python_Toolkit#183
Issues addressed by this PR
Closes #311
See linked PR for more info.
Deprecated a couple of the inputs for the plot_windrose method as they no longer made any sense now that the polar plot method exists in Python_Toolkit.
Test files
Run unit tests and ensure they pass
Check the Wind class using jupyter to see that it works properly: import wind from an EPW file or openmeteo and try creating a number of different wind roses.
Changelog
Windclass toPython_ToolkitAdditional comments