Skip to content

chore: fix modal bug #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix modal bug #2480

wants to merge 1 commit into from
+60 −21

Conversation

adithyaakrishna
Copy link
Contributor

Description:

  • Add dismissible properties to modal bottom sheet for tap-outside and drag-down closing
  • Update Done button to always close modal regardless of selection state
  • Add explicit close button in top-right corner of modal
  • Implement proper controller cleanup in dispose method
  • Add error handling wrapper around modal display
  • Add WillPopScope wrapper to handle back button/gesture properly

Issue Links:

Fixes #2475

@vercel Vercel
Copy link

vercel bot commented May 30, 2025

@adithyaakrishna is attempting to deploy a commit to the kodjima33's projects Team on Vercel.

A member of the Team first needs to authorize it.

@adithyaakrishna
Copy link
Contributor Author

@thinhx Would love to get your review this

@beastoin
Copy link
Collaborator

beastoin commented Jun 1, 2025 •
edited
Loading

1/ what is the reason of the issue ? i mean 'doesn't work

---
Screenshot 2025-06-01 at 19 05 57
---

fyi the primary language is required.

@adithyaakrishna

@kodjima33
Copy link
Collaborator

@beastoin when installing locally the popup doesn't work, ie when button is clicked = nothing happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

critical bug = primary language
3 participants
@adithyaakrishna @beastoin @kodjima33