PC Engines #211
PC Engines #211
Conversation
variables.robot
Outdated
| @@ -40,9 +40,9 @@ ${OS_UBUNTU}= ubuntu | |||
| &{RTE10}= ip=192.168.10.173 cpuid=02c00042a3b72a65 pcb_rev=0.5.3 | |||
| ... platform=apu3 board-revision=c4 env=prod | |||
| ... platform_vendor=PC Engines firmware_type=BIOS | |||
| &{RTE11}= ip=192.168.10.174 cpuid=02c000426621f7ea pcb_rev=0.5.3 | |||
| &{RTE11}= ip=192.168.10.174 cpuid=02c000426621f7ea pcb_rev=1.0.0 | |||
There was a problem hiding this comment.
Are we sure? IIUC most recent version is v1.1.0
There was a problem hiding this comment.
That's what snipeit contains, I haven't checked the actual hardware yet
There was a problem hiding this comment.
@mkopec I would appreciate if that would be checked, maybe snipeit contain wrong information.
There was a problem hiding this comment.
IIUC most recent version is v1.1.0
It is but we do not use it for PC Engines. The v1.1.0 is too precious to use on platforms not strictly requiring it. We are short on RTEs.
There was a problem hiding this comment.
Also, this information is not used at all in tests AFAIR
There was a problem hiding this comment.
Another thing to remove
There was a problem hiding this comment.
Removed the pcb_rev variable in commit f6cfcd1 . It makes more sense to track this type of information in snipeit.
|
@macpijan decided to split up the README into separate files, as it's grown in size quite a bit. I'll be adding the docs for adding new mainboards to a separate document. |
docs/adding-new-platforms.md
Outdated
| - Modify the file for your platform: | ||
| - Modify the settings appropriately for your mainboard | ||
| - Remove any unmodified lines - they will be sourced from `default.robot` | ||
| - Add the platform configuration to `variables.robot: |
There was a problem hiding this comment.
I hate the complexity and redundancy of this file, but yes, let's better document what we have and improve gradually.
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
No description provided.