proposal: contrib/cloud.google.com/go/pubsub.v1 should support custom resource names #3719
bendiknesbo
started this conversation in
Feature Request
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Package Name
contrib/cloud.google.com/go/pubsub
Package Version(s)
2.0.1
Describe the feature you'd like
The contrib for cloud.google.com/go/pubsub.v1 does not support a way to override the resource-name for the span, so it always ends up as
projects/<project-id>/topics/<topic-id>
(as a result oftracer.ResourceName(topic.String())
being passed totracer.StartSpanFromContext
: https://github.com/DataDog/dd-trace-go/blob/v2.0.1/contrib/cloud.google.com/go/pubsub.v1/internal/tracing/tracing.go#L50The only options we can pass is to override the Service-name or setting
Measured
.We would like the ability to specify the
resource
, so that it's easier for us to grok what messages are being sent on PubSub.Is your feature request related to a problem?
No response
Describe alternatives you've considered
No response
Additional context
No response
Beta Was this translation helpful? Give feedback.
All reactions