Skip to content

[BUG] #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monkeylumps opened this issue Jan 25, 2025 · 5 comments
Open

[BUG] #185

monkeylumps opened this issue Jan 25, 2025 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@monkeylumps
Copy link

What steps will reproduce the problem?

  1. Client 1.15.5.58555
  2. add ShestakUI with config as a fresh addon
  3. load out of date addons
  4. load into game
  5. lua error

What version of ShestakUI are you using? (Stating 'latest' is not useful)

Latest Wetxius latest master as pf 25/01/25

Do you have an error log of what happened?

Message: ...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:133: attempt to call field 'CONFIG' (a nil value)
Time: Sat Jan 25 01:10:29 2025
Count: 1
Stack: ...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:133: attempt to call field 'CONFIG' (a nil value)
[string "=[C]"]: in function CONFIG' [string "@Interface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua"]:133: in function ?'
[string "@Interface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua"]:371: in function <...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:367>
[string "@Interface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua"]:451: in function <...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:447>

Locals:

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

/config, /cfg don't work but the UI menu to open the config throws this error

maybe related it the UI scaling reset every time the UI is reloaded or relog

@monkeylumps monkeylumps added the bug Something isn't working label Jan 25, 2025
@monkeylumps
Copy link
Author

This is still an issue.

@hehooisbored
Copy link

Can you try removing the#RequiredDep: ShestakUI from your ShestakUI_Config_Vanilla.toc file, and see if that changes anything for you?

@monkeylumps
Copy link
Author

done but still same error

Message: ...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:133: attempt to call field 'CONFIG' (a nil value)
Time: Tue Feb 25 11:54:16 2025
Count: 1
Stack: ...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:133: attempt to call field 'CONFIG' (a nil value)
[string "=[C]"]: in function CONFIG' [string "@Interface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua"]:133: in function ?'
[string "@Interface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua"]:371: in function <...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:367>
[string "@Interface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua"]:451: in function <...terface/AddOns/ShestakUI/Modules/Maps/ToggleMenu.lua:447>

Locals:

@hehooisbored
Copy link

Okay, you can try downloading the copy from my fork. It looks like the same bug I was seeing on MacOS, with ShestakUI loading before ShestakUI_Config was loaded. I made an adjustment to the toc's which have worked so far, and might help. Still looking into a better way to make sure startup processes correctly.

@monkeylumps
Copy link
Author

monkeylumps commented Feb 27, 2025

Tried to take just the ShestakUI_Config_Vanilla.toc from hehooisbored fork but that did not fix the issues

I then downloaded and replaced the both ShestakUI and ShestakUI config folders with hehooisbored classic version.

I was then unable to see if the fix worked or not has it has the same issue as the EsreverWoW
main version, which is a loop of lua errors.

This has been fixed in Wetxius version with these two changes

Wetxius/ShestakUI_Classic@5403571...aa92250
Wetxius/ShestakUI_Classic@aa92250...a9f734e

@hehooisbored can you add these changes to your fork?
@Wetxius if @hehooisbored cant add the changes to his fork could you take a look at this issue please

this is the old bug I raised for the above for info - #184

Maybe does not matter but one thing I have been thinking about is I don't have duel spec only any toon I have used this UI with, maybe there is something around that.

hehooisbored added a commit to Wetxius/ShestakUI_Classic that referenced this issue Apr 27, 2025
Bump build numbers
Swap RequiredDeps to force ShestakUI_Config to load first (Bug EsreverWoW#185 from EsReaver)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants