-
-
Notifications
You must be signed in to change notification settings - Fork 209
Change interface of fem.petsc.create_vector
to allow for general list of function spaces
#3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schnellerhase
wants to merge
22
commits into
FEniCS:main
Choose a base branch
from
schnellerhase:create_vector_from_spaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Change interface of fem.petsc.create_vector
to allow for general list of function spaces
#3694
schnellerhase
wants to merge
22
commits into
FEniCS:main
from
schnellerhase:create_vector_from_spaces
+130
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9591f98
to
7e9c3e2
Compare
garth-wells
reviewed
Apr 9, 2025
la.petsc.create_vector
to allow for general list of function spacesfem.petsc.create_vector
to allow for general list of function spaces
francesco-ballarin
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of PETSc vectors relies internally on a list of tuples
(IndexMap, bs)
. Given a list of such and a vector kind we can create the corresponding coefficient vector. Previously this functionality was not exposed to the user directly and only supported indirectly by passing aForm
from which the spaces would then be extracted.la.petsc.create_vector
which now takes a list of(IndexMap, bs)
tuples and returns aPETSc.Vec
object. The interface offem.petsc.create_vector
is extended to allow for function spaces as input as well. Vectors can therefore now be create by a list of function spaces:b = dolfinx.fem.create_vector([V, W])
and no longer require a form to be present for such construction. And alternatively from a general sequence of index maps and blocks sizes, without the presence of any function spaces withla.petsc.create_vector
._assign_block_data
which factors out the attachment of block information to PETSc vectors.