Skip to content

Commit f79df5c

Browse files
herbetomgenofire
authored andcommitted
feat(data): handle gluon target information
1 parent ed31b46 commit f79df5c

File tree

16 files changed

+73
-25
lines changed

16 files changed

+73
-25
lines changed

config_example.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ password = ""
213213
# Tagging of the data (optional)
214214
[database.connection.influxdb.tags]
215215
# Tags used by Yanic would override the tags from this config
216-
# nodeid, hostname, owner, model, firmware_base, firmware_release,frequency11g and frequency11a are tags which are already used
216+
# nodeid, hostname, owner, model, firmware_base, firmware_release, firmware_target, firmware_subtarget, firmware_image_name, frequency11g and frequency11a are tags which are already used
217217
#tagname1 = "tagvalue 1"
218218
# some useful e.g.:
219219
#system = "productive"
@@ -255,7 +255,7 @@ global = "yanic-persistent"
255255
# Tagging of the data (optional)
256256
[database.connection.influxdb2.tags]
257257
# Tags used by Yanic would override the tags from this config
258-
# nodeid, hostname, owner, model, firmware_base, firmware_release,frequency11g and frequency11a are tags which are already used
258+
# nodeid, hostname, owner, model, firmware_base, firmware_release, firmware_target, firmware_subtarget, firmware_image_name, frequency11g and frequency11a are tags which are already used
259259
#tagname1 = "tagvalue 1"
260260
# some useful e.g.:
261261
#system = "productive"

data/nodeinfo.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,11 @@ type Software struct {
7575
PublicKey string `json:"public_key,omitempty"`
7676
} `json:"fastd,omitempty"`
7777
Firmware *struct {
78-
Base string `json:"base,omitempty"`
79-
Release string `json:"release,omitempty"`
78+
Base string `json:"base,omitempty"`
79+
Release string `json:"release,omitempty"`
80+
Target string `json:"target,omitempty"`
81+
Subtarget string `json:"subtarget,omitempty"`
82+
ImageName string `json:"image_name,omitempty"`
8083
} `json:"firmware,omitempty"`
8184
StatusPage *struct {
8285
API int `json:"api"`

data/nodeinfo_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ func TestNodeinfo(t *testing.T) {
3434

3535
assert.Equal("gluon-v2016.1.2", obj.Software.Firmware.Base)
3636
assert.Equal("2016.1.2+bremen1", obj.Software.Firmware.Release)
37+
assert.Equal("mpc85xx", obj.Software.Firmware.Target)
38+
assert.Equal("p1010", obj.Software.Firmware.Subtarget)
39+
assert.Equal("tp-link-tl-wdr4900-v1", obj.Software.Firmware.ImageName)
3740

3841
assert.Equal("TP-Link TL-WDR4900 v1", obj.Hardware.Model)
3942
}

data/testdata/nodeinfo.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414
},
1515
"firmware": {
1616
"base": "gluon-v2016.1.2",
17-
"release": "2016.1.2+bremen1"
17+
"release": "2016.1.2+bremen1",
18+
"target": "mpc85xx",
19+
"subtarget": "p1010",
20+
"image_name": "tp-link-tl-wdr4900-v1"
1821
},
1922
"status-page": {
2023
"api": 1

database/influxdb/global_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,11 @@ func createTestNodes() *runtime.Nodes {
135135
},
136136
}
137137
nodeData.Nodeinfo.Software.Firmware = &struct {
138-
Base string `json:"base,omitempty"`
139-
Release string `json:"release,omitempty"`
138+
Base string `json:"base,omitempty"`
139+
Release string `json:"release,omitempty"`
140+
Target string `json:"target,omitempty"`
141+
Subtarget string `json:"subtarget,omitempty"`
142+
ImageName string `json:"image_name,omitempty"`
140143
}{
141144
Release: "2016.1.6+entenhausen1",
142145
}

database/influxdb/node.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ func (conn *Connection) InsertNode(node *runtime.Node) {
8484
if nodeinfo.Software.Firmware != nil {
8585
tags.SetString("firmware_base", nodeinfo.Software.Firmware.Base)
8686
tags.SetString("firmware_release", nodeinfo.Software.Firmware.Release)
87+
tags.SetString("firmware_target", nodeinfo.Software.Firmware.Target)
88+
tags.SetString("firmware_subtarget", nodeinfo.Software.Firmware.Subtarget)
89+
tags.SetString("firmware_image_name", nodeinfo.Software.Firmware.ImageName)
8790
}
8891
if nodeinfo.Software.Autoupdater != nil && nodeinfo.Software.Autoupdater.Enabled {
8992
tags.SetString("autoupdater", nodeinfo.Software.Autoupdater.Branch)

database/influxdb/node_test.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,16 @@ func TestToInflux(t *testing.T) {
118118
Enabled: false,
119119
},
120120
Firmware: &struct {
121-
Base string `json:"base,omitempty"`
122-
Release string `json:"release,omitempty"`
121+
Base string `json:"base,omitempty"`
122+
Release string `json:"release,omitempty"`
123+
Target string `json:"target,omitempty"`
124+
Subtarget string `json:"subtarget,omitempty"`
125+
ImageName string `json:"image_name,omitempty"`
123126
}{
124127
Base: "gluon",
128+
Target: "x86",
129+
Subtarget: "64",
130+
ImageName: "x86-64",
125131
},
126132
},
127133
},

database/influxdb2/node.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ func (conn *Connection) InsertNode(node *runtime.Node) {
7474
if nodeinfo.Software.Firmware != nil {
7575
p.AddTag("firmware_base", nodeinfo.Software.Firmware.Base)
7676
p.AddTag("firmware_release", nodeinfo.Software.Firmware.Release)
77+
p.AddTag("firmware_target", nodeinfo.Software.Firmware.Target)
78+
p.AddTag("firmware_subtarget", nodeinfo.Software.Firmware.Subtarget)
79+
p.AddTag("firmware_image_name", nodeinfo.Software.Firmware.ImageName)
7780
}
7881
if nodeinfo.Software.Autoupdater != nil && nodeinfo.Software.Autoupdater.Enabled {
7982
p.AddTag("autoupdater", nodeinfo.Software.Autoupdater.Branch)

output/geojson/geojson_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,11 @@ func createTestNodes() *runtime.Nodes {
8686
},
8787
}
8888
nodeData.Nodeinfo.Software.Firmware = &struct {
89-
Base string `json:"base,omitempty"`
90-
Release string `json:"release,omitempty"`
89+
Base string `json:"base,omitempty"`
90+
Release string `json:"release,omitempty"`
91+
Target string `json:"target,omitempty"`
92+
Subtarget string `json:"subtarget,omitempty"`
93+
ImageName string `json:"image_name,omitempty"`
9194
}{
9295
Release: "2019.1~exp42",
9396
}

output/meshviewer-ffrgb/struct.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,11 @@ type Node struct {
5050

5151
// Firmware out of software
5252
type Firmware struct {
53-
Base string `json:"base,omitempty"`
54-
Release string `json:"release,omitempty"`
53+
Base string `json:"base,omitempty"`
54+
Release string `json:"release,omitempty"`
55+
Target string `json:"target,omitempty"`
56+
Subtarget string `json:"subtarget,omitempty"`
57+
ImageName string `json:"image_name,omitempty"`
5558
}
5659

5760
// Autoupdater

0 commit comments

Comments
 (0)