Skip to content

Commit 8aa8f06

Browse files
committed
Update to ensure all console outputs require debug
1 parent 3018c12 commit 8aa8f06

File tree

4 files changed

+13
-14
lines changed

4 files changed

+13
-14
lines changed

jquery.cacheImages.indexeddb.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ window.indexedDB = window.indexedDB || window.mozIndexedDB || window.webkitIndex
1414
if( $.fn.cacheImages.defaults.debug ){ console.log('cacheImages will use indexedDB '); }
1515

1616
/* -- Setup everything we need for the database -- */
17+
var cacheImagesDb; // used to hold the db reference
1718
if( typeof $.fn.cacheImages.defaults.indexedDbName === 'undefined' ){ $.fn.cacheImages.defaults.indexedDbName = 'cacheImages'; } // Needs to be defined prior to instantiating this script - but after including the primary cacheImages script
1819
$.fn.cacheImages.dbRequest = window.indexedDB.open( $.fn.cacheImages.defaults.indexedDbName, 1 );
19-
var cacheImagesDb; // used to hold the db reference
2020
$.fn.cacheImages.defaults.indexedDbStatus = false;
2121

2222
// Enable
@@ -41,7 +41,7 @@ window.indexedDB = window.indexedDB || window.mozIndexedDB || window.webkitIndex
4141
//Create Note
4242
if(!thisDb.objectStoreNames.contains("offlineImages")) {
4343
// Structure is key, image
44-
console.log("making the offlineImages objectstore");
44+
if( $.fn.cacheImages.defaults.debug ){ console.log("making the offlineImages objectstore"); }
4545
var objectStore = thisDb.createObjectStore("offlineImages", { keyPath: "key" });
4646
var titleIndex = objectStore.createIndex("by_key", "key", {unique: true});
4747
}
@@ -154,8 +154,7 @@ window.indexedDB = window.indexedDB || window.mozIndexedDB || window.webkitIndex
154154
* Will remove all of the cached images from their localStorage
155155
*/
156156
$.fn.cacheImages.drop = function( url, storagePrefix ){
157-
var dropKeys = [], // Store the keys we need to drop here
158-
debug = false;
157+
var dropKeys = []; // Store the keys we need to drop here
159158
if( typeof storagePrefix === 'undefined' ){ storagePrefix = $.fn.cacheImages.defaults.storagePrefix; }
160159
if( typeof url === 'undefined' ){ url = null; }
161160

@@ -172,20 +171,20 @@ window.indexedDB = window.indexedDB || window.mozIndexedDB || window.webkitIndex
172171
cursor.continue();
173172
}else{
174173
// No more matching records.
175-
console.log('No more matching records');
174+
if( $.fn.cacheImages.defaults.debug ){ console.log('No more matching records'); }
176175

177176
if( dropKeys.length === 0 ){
178-
if( debug ){ console.log( 'No Images to Drop' ); }
177+
if( $.fn.cacheImages.defaults.debug ){ console.log( 'No Images to Drop' ); }
179178
return true;
180179
}
181180

182181
// Drop the keys we found
183182
for( i = 0; i < dropKeys.length; i++ ){
184-
if( debug ){ console.log( 'Dropping localStorage Key:', dropKeys[i] ); } // Let them know what keys were dropped
183+
if( $.fn.cacheImages.defaults.debug ){console.log( 'Dropping localStorage Key:', dropKeys[i] ); } // Let them know what keys were dropped
185184
window.cacheImagesDb.transaction("offlineImages", "readwrite").objectStore("offlineImages").delete( dropKeys[i] );
186185
}
187186

188-
if( debug ){ console.log( 'Dropped ' + dropKeys.length + ' images from indexedDB' ); } // Provide a bit of feedback for developers
187+
if( $.fn.cacheImages.defaults.debug ){ console.log( 'Dropped ' + dropKeys.length + ' images from indexedDB' ); } // Provide a bit of feedback for developers
189188
return true;
190189
}
191190
};

jquery.cacheImages.indexeddb.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jquery.cacheImages.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* @author Paul Prins
88
* @link http://paulprins.net
9-
* @version 1.3.0
9+
* @version 1.5.0
1010
* @requires jQuery v1.7 or later
1111
*
1212
* Official jQuery plugin page:
@@ -320,17 +320,17 @@
320320
}
321321

322322
if( dropKeys.length === 0 ){
323-
if( debug ){ console.log( 'No Images to Drop' ); }
323+
if( $.fn.cacheImages.defaults.debug ){ console.log( 'No Images to Drop' ); }
324324
return;
325325
}
326326

327327
// Drop the keys we found
328328
for( i = 0; i < dropKeys.length; i++ ){
329-
if( debug ){ console.log( 'Dropping localStorage Key:', dropKeys[i] ); } // Let them know what keys were dropped
329+
if( $.fn.cacheImages.defaults.debug ){ console.log( 'Dropping localStorage Key:', dropKeys[i] ); } // Let them know what keys were dropped
330330
window.localStorage.removeItem( dropKeys[i] );
331331
}
332332

333-
if( debug ){ console.log( 'Dropped ' + dropKeys.length + ' images from storage' ); } // Provide a bit of feedback for developers
333+
if( $.fn.cacheImages.defaults.debug ){ console.log( 'Dropped ' + dropKeys.length + ' images from storage' ); } // Provide a bit of feedback for developers
334334
return;
335335
};
336336
})(jQuery);

0 commit comments

Comments
 (0)