Library/AC: Optimize and Prevent getting account roles for guest player

Author: Nightprince

application/models/Acl_model.php

@@ -41,6 +41,9 @@ public function __construct()
      */
     public function getGroupRolesByUser(int $userId, false|string $moduleName = false): array
     {
+        if ($userId == 0)
+            return [];
+
         $query = $this->db->table('acl_group_roles agr')
             ->select('agr.role_name, agr.module')
             ->join('acl_account_groups aag', 'aag.group_id = agr.group_id', 'inner')
@@ -116,6 +119,9 @@ public function getAccountRolesPermissions(int $userId = 0, int $default_group =
      */
     public function getAccountPermissions(int $userId): array
     {
+        if ($userId == 0)
+            return [];
+
         $query = $this->db->table('acl_account_permissions')->select("account_id, permission_name, module, value")->where("account_id", $userId)->get();
 
         return $query->getResultArray() ?? [];
@@ -130,6 +136,9 @@ public function getAccountPermissions(int $userId): array
      */
     public function getAccountRoles(int $userId, false|string $module = false): array
     {
+        if ($userId == 0)
+            return [];
+
         $builder = $this->db->table('acl_account_roles')->select("role_name")->where("account_id", $userId);
 
         if ($module) {
@@ -151,6 +160,9 @@ public function getGroupsByUser(false|int $accountId = false): array
             $accountId = $this->user->getId();
         }
 
+        if ($accountId == 0)
+            return [];
+
         $builder = $this->db->table("acl_account_groups aag, acl_groups ag");
         $builder->select("ag.id, ag.priority, ag.name, ag.color, ag.color");
         $builder->where("aag.account_id", $accountId);