Library/Template: Optimize load sideboxes

Author: Nightprince

application/libraries/Template.php

@@ -268,9 +268,10 @@ public function view(string $content, bool|string|array $css = false, bool|strin
     private function handleNormalPage($content, bool|string|array$css, bool|string|array$js): mixed
     {
         //Load the sideboxes
-        $sideboxes        = $this->loadSideboxes();
-        $sideboxes_top    = $this->loadSideboxes('top');
-        $sideboxes_bottom = $this->loadSideboxes('bottom');
+        $sideboxes = $this->loadSideboxes();
+        $sideboxes_side   = $sideboxes['side'] ?? [];
+        $sideboxes_top    = $sideboxes['top'] ?? [];
+        $sideboxes_bottom = $sideboxes['bottom'] ?? [];
         $header           = $this->getHeader($css, $js);
         $modals           = $this->getModals();
 
@@ -298,7 +299,7 @@ private function handleNormalPage($content, bool|string|array$css, bool|string|a
             "image_path" => $this->image_path,
             "isOnline" => $this->CI->user->isOnline(),
             "isRTL" => $this->CI->language->getLanguage() == 'persian' || $this->CI->language->getClientData() == 'persian',
-            "sideboxes" => $sideboxes,
+            "sideboxes" => $sideboxes_side,
             "sideboxes_top" => $sideboxes_top,
             "sideboxes_bottom" => $sideboxes_bottom
         ];
@@ -454,16 +455,23 @@ private function voteReminder(): bool|string
     /**
      * Loads the sideboxes, and returns the result
      *
-     * @param string $location
      * @return array
      */
-    public function loadSideboxes(string $location = 'side'): array
+    public function loadSideboxes(): array
     {
-        $output = [];
+        $output = [
+            'side' => [],
+            'top' => [],
+            'bottom' => [],
+        ];
+
         $module = CI::$APP->router->fetch_module();
-        $sideBoxes = $this->CI->cms_model->getSideboxes($location, $module);
 
-        foreach ((array) $sideBoxes as $sideBox) {
+        $allSideboxes = $this->CI->cms_model->getSideboxes($module);
+
+        foreach ((array) $allSideboxes as $sideBox) {
+            $location = $sideBox['location'] ?? 'side';
+
             if ($sideBox['permission'] && !hasViewPermission($sideBox['permission'], "--SIDEBOX--")) {
                 continue;
             }
@@ -472,7 +480,7 @@ public function loadSideboxes(string $location = 'side'): array
             $fileLocation = APPPATH . 'modules/sidebox_' . $sideboxType . '/controllers/' . ucfirst($sideboxType) . '.php';
 
             if (!file_exists($fileLocation)) {
-                $output[] = [
+                $output[$location][] = [
                     'name' => "Oops, something went wrong",
                     'data' => 'The following sideBox module is missing or contains an invalid module structure: <b>sidebox_' . $sideboxType . '</b>'
                 ];
@@ -483,9 +491,9 @@ public function loadSideboxes(string $location = 'side'): array
 
             $object = ($sideboxType === 'custom') ? new $sideboxType($sideBox['id']) : new $sideboxType();
 
-            $output[] = [
+            $output[$location][] = [
                 'name'     => langColumn($sideBox['displayName']),
-                'location' => $sideBox['location'],
+                'location' => $location,
                 'data'     => $object->view(),
                 'type'     => $sideboxType,
             ];

application/models/Cms_model.php

@@ -39,17 +39,13 @@ private function logVisit()
         }
     }
 
-    public function getSideboxes(string $type = 'side', string $page = '*')
+    public function getSideboxes(string $page = '*'): array
     {
         // Query: Prepare
         $query = $this->db->table('sideboxes')
                           ->select('*')
                           ->orderBy('order', 'ASC');
 
-        // Query: Filter (Type)
-        if($type && in_array($type, ['top', 'side', 'bottom']))
-            $query = $query->where('location', $type);
-
         // Query: Filter (Page)
         if($page && $page !== '*')
             $query = $query->groupStart()