Module/Online: Rewrite and optimize load online characters

* now use data table
* have pagination
* split realm characters
* better performance
* the cache is cleaner
* now have loading before load data

Author: Nightprince

application/modules/online/controllers/Online.php

@@ -8,39 +8,77 @@ public function __construct()
     {
         parent::__construct();
 
-        requirePermission("view");
+        requirePermission('view');
+        $this->load->config('online');
     }
 
     public function index()
     {
-        $this->template->setTitle(lang("online_players", "online"));
+        clientLang("no_players", "online");
+        clientLang("offline", "online");
 
-        $cache = $this->cache->get("online_module");
+        $this->template->setTitle(lang('online_players', 'online'));
+
+        $content_data = [
+            'realms' => $this->realms->getRealms(),
+            'url' => $this->template->page_url,
+        ];
+
+        $page_content = $this->template->loadPage('online.tpl', $content_data);
+
+        //Load the page
+        $page_data = [
+            'module' => 'default',
+            'headline' => lang('online_players', 'online'),
+            'content' => $page_content
+        ];
+
+        $page = $this->template->loadPage('page.tpl', $page_data);
+
+        $this->template->view($page, 'modules/online/css/online.css', 'modules/online/js/online.js');
+    }
+
+    public function online_refresh($realm_id = 0)
+    {
+        $realm = $this->realms->getRealm($realm_id);
+
+        if (!$realm || !$realm->isOnline()) {
+            echo json_encode(['status' => 'offline']);
+            return;
+        }
+
+        $cache = $this->cache->get('online_list_' . $realm_id);
 
-        // Perform ajax call to refresh if expired
         if ($cache !== false) {
-            $page = $cache;
-        } else {
-            // Prepare data
-            $data = [
-                "module" => "online",
-                "image_path" => $this->template->image_path
-            ];
+            echo json_encode(['status' => 'ok', 'data' => $cache]);
+            return;
+        }
 
-            // Load the template file and format
-            $ajax = $this->template->loadPage("ajax.tpl", $data);
+        $hide_gms = $this->config->item('hide_gms');
+        $players = $realm->getCharacters()->getOnlinePlayers($hide_gms);
 
-            // Load the topsite page and format the page contents
-            $data2 = [
-                "module" => "default",
-                "headline" => lang("online_players", "online"),
-                "content" => $ajax
-            ];
+        if (empty($players)) {
+            echo json_encode(['status' => 'empty', 'data' => []]);
+            return;
+        }
 
-            $page = $this->template->loadPage("page.tpl", $data2);
+        $data = [];
+
+        foreach ($players as $character) {
+            $data[] = [
+                "guid" => $character['guid'],
+                "name" => $character['name'],
+                "level" => $character['level'],
+                "race" => $character['race'],
+                "gender" => $character['gender'],
+                "class" => $character['class'],
+                "zone" => $this->realms->getZone($character['zone'])
+            ];
         }
 
-        //Load the template form
-        $this->template->view($page, "modules/online/css/online.css", "modules/online/js/sort.js");
+        $this->cache->save('online_list_' . $realm_id, $data, 60 * 5);
+
+        echo json_encode(['status' => 'ok', 'data' => $data]);
     }
+
 }

application/modules/online/controllers/Online_refresh.php

@@ -0,0 +1,81 @@
+let table;
+
+function showSpinner() {
+	$('#playersTableContainer').html(`
+        <div class="text-center p-4">
+            <i class="fas fa-spinner fa-spin fa-2x"></i>
+        </div>
+    `);
+}
+
+function loadRealm(realmId) {
+	if (!realmId) {
+		$('#playersTableContainer').hide();
+		return;
+	}
+	showSpinner();
+	$('#playersTableContainer').show();
+
+	$.ajax({
+		url: Config.URL + 'online/online_refresh/' + realmId,
+		method: 'GET',
+		dataType: 'json',
+		success: function (response) {
+			if (table) {
+				table.clear().destroy();
+				$('#playersTable').remove();
+			}
+
+			if (response.status === "offline") {
+				$('#playersTableContainer').html('<div class="alert alert-danger text-center">' + lang("offline", "online") + '</div>');
+				return;
+			}
+
+			if (response.status === "empty") {
+				$('#playersTableContainer').html('<div class="alert alert-warning text-center">' + lang("no_players", "online") + '</div>');
+				return;
+			}
+
+			$('#playersTableContainer').html('<table id="playersTable" class="nice_table"></table>');
+
+			const tableData = response.data.map(char => {
+				return [
+					`<a href="${Config.URL}character/${realmId}/${char.guid}">${char.name}</a>`,
+					char.level,
+					`<img src="${Config.URL}application/images/stats/${char.race}-${char.gender}.gif">`,
+					`<img src="${Config.URL}application/images/stats/${char.class}.gif">`,
+					char.zone
+				];
+			});
+
+			table = $('#playersTable').DataTable({
+				data: tableData,
+				columns: [
+					{ title: "Character" },
+					{ title: "Level" },
+					{ title: "Race" },
+					{ title: "Class" },
+					{ title: "Location" }
+				],
+				deferRender: true,
+				paging: true,
+				searching: true,
+				processing: true
+			});
+		},
+		error: function () {
+			$('#playersTableContainer').html('<div class="alert alert-danger text-center">Error loading players</div>');
+		}
+	});
+}
+
+$(document).ready(function () {
+	$('#realmSelect').on('change', function () {
+		loadRealm($(this).val());
+	});
+
+	const firstRealmId = $('#realmSelect option:nth-child(1)').val();
+	if (firstRealmId) {
+		$('#realmSelect').val(firstRealmId).trigger('change');
+	}
+});

application/modules/online/js/online.js

@@ -21,3 +21,4 @@
 $lang['offline'] = "Offline";
 $lang['view_profile'] = "View character profile";
 $lang['online_players'] = "Online players";
+$lang['realm'] = "Realm";

application/modules/online/js/sort.js

@@ -21,3 +21,4 @@
  $lang['offline'] = "Hors ligne";
  $lang['view_profile'] = "Voir le profil du personnage";
  $lang['online_players'] = "Joueurs en ligne";
+$lang['realm'] = "Royaume";

application/modules/online/language/english/online.php

@@ -21,3 +21,4 @@
 $lang['offline'] = "آفلاین";
 $lang['view_profile'] = "نمایش پروفایل شخصیت";
 $lang['online_players'] = "بازیکنان آنلاین";
+$lang['realm'] = "ریلم";

application/modules/online/language/france/online.php

@@ -25,3 +25,4 @@
 $lang['offline'] = "Offline";
 $lang['view_profile'] = "Ver perfil do personagem";
 $lang['online_players'] = "Jogadores online";
+$lang['realm'] = "Reino";

application/modules/online/language/persian/online.php

@@ -20,4 +20,5 @@
 $lang['no_players'] = "No hay jugadores en línea";
 $lang['offline'] = "Desconectado";
 $lang['view_profile'] = "Ver perfil de personaje";
-$lang['online_players'] = "Jugadores en línea";
+$lang['online_players'] = "Jugadores en línea";
+$lang['realm'] = "Reino";

application/modules/online/language/portuguese-brazilian/online.php

@@ -1,8 +1,8 @@
 {
 	"name": "Online players",
 	"description": "Displays all online characters",
-	"version": "2.0.0",
-	"date": "2023-05-30",
+	"version": "3.0.0",
+	"date": "2025-05-22",
 	"author": {
 		"name": "FusionCMS",
 		"website": "https://github.com/FusionWowCMS/FusionCMS"