Do not automatically include new form fields into export feeds

[rafaehlers]

A user reported:

I heavily use the GravityExport Filters. Adding a new field to the form it is tied to automatically adds that new field to the Enabled Fields for all existing filter feeds. I then have to manually remove it from every one. At any given time there are more than 50 active feeds in my system, so this is a real pain. Is this designed behavior? If so, is there a way to turn it off? I need to make some more edits to my form and want to understand my options on how this works before proceeding.

Might be useful to implement this on GravityExport (PRO) as well.

Here's a video: https://www.loom.com/share/46fdd20aaab74846a35f8266d4913fa3

Steps to reproduce:

• Go to the GravityExport tab in the form settings and leave only one field in the "Enabled Fields" panel

• Go to the form and add a new field

• Check the GravityExport feed again. The new field will be automatically added to the feed. Let's prevent this from happening.

Tested on GravityExport Lite version 2.3.5 and GFs 2.9

[rafaehlers]

https://secure.helpscout.net/conversation/2775658885/59423

[doekenorg]

Let's make this a setting, because it is designed behaviour. There are reasons for both options.

[rafaehlers]

It appears that this is still an issue. I've avoided adding any new fields to my form, but recently had to do so, and the problem still persists. It's been almost 6 months and I had assumed the bug would have been fixed by now.

Do you know when this will be resolved? Thanks.

It looks like an entry meta from Gravity PDF is being added in her case, so we must ensure that new entry metals are not automatically added as well.

Wow, that's above and beyond. In fact, I did a little more digging and it is NOT a new field on my form (i have dozens of forms so it's hard to keep track of it in my head!), but seems instead to be related to a new plugin I'm testing called GravityPDF. I recently installed that plugin and am doing some testing. The field name in question that now appears on the GravityExport list is "PDF: Roster Test"

[doekenorg]

@rafaehlers here is a solution for now:

/**
 * Disable new (unsaved) fields automatically.
 */
use GFExcel\Repository\FieldsRepository;

add_filter( 'gfexcel_disabled_fields', function ( $fields, $form_id, $feed_id ) {
    $form = GFAPI::get_form( $form_id );
    $feed = GFAPI::get_feed( $feed_id );
    if ( ! $feed || ! $form ) {
        return $fields;
    }

    $repository = new FieldsRepository( $form, $feed );
    
    $all_field_ids      = array_column( $repository->getFields( true ), 'id' );
    $disabled_field_ids = array_diff( $all_field_ids, $repository->getEnabledFields() );
    $unsaved_fields     = array_diff( $disabled_field_ids, $fields );

    return array_merge( $fields, $unsaved_fields );
}, 10, 3 );

It should also ignore new meta fields. But please make sure if you can.