Remove remaining in-source HLINT pragmas

Author: newhoggy

.hlint.yaml

@@ -60,7 +60,9 @@
 # Allow snake_case naming in test modules (following Haskell test property convention)
 - ignore: {name: Use camelCase, within: [Test.Cardano.Api.**, Test.Golden.Cardano.Api.**]}
 
+- ignore: {name: Eta reduce}
 - ignore: {name: Use + directly}
+- ignore: {name: Use fmap}
 
 # Define some custom infix operators
 # - fixity: infixr 3 ~^#^~

cardano-api/src/Cardano/Api/Address.hs

@@ -9,8 +9,6 @@
 {-# LANGUAGE TypeApplications #-}
 {-# LANGUAGE TypeFamilies #-}
 
-{- HLINT ignore "Avoid lambda using `infix`" -}
-
 -- | Cardano addresses: payment and stake addresses.
 module Cardano.Api.Address
   ( -- * Payment addresses

cardano-api/src/Cardano/Api/Block.hs

@@ -82,9 +82,6 @@ import Data.ByteString.Short qualified as SBS
 import Data.Foldable (Foldable (toList))
 import Data.Text (Text)
 
-{- HLINT ignore "Use lambda" -}
-{- HLINT ignore "Use lambda-case" -}
-
 -- ----------------------------------------------------------------------------
 -- Blocks in an era
 --

cardano-api/src/Cardano/Api/Byron/Internal/Proposal.hs

@@ -57,12 +57,11 @@ import Ouroboros.Consensus.Byron.Ledger.Mempool qualified as Mempool
 
 import Data.ByteString (ByteString)
 import Data.ByteString.Lazy qualified as LB
+import Data.Functor (void)
 import Data.Map.Strict qualified as M
 import Data.Word
 import Numeric.Natural
 
-{- HLINT ignore "Use void" -}
-
 -- | Byron era update proposal
 newtype ByronUpdateProposal
   = ByronUpdateProposal {unByronUpdateProposal :: AProposal ByteString}
@@ -193,7 +192,7 @@ instance HasTypeProxy ByronVote where
   proxyToAsType _ = AsByronVote
 
 instance SerialiseAsRawBytes ByronVote where
-  serialiseToRawBytes (ByronVote vote) = Binary.serialize' $ fmap (const ()) vote
+  serialiseToRawBytes (ByronVote vote) = Binary.serialize' $ void vote
   deserialiseFromRawBytes AsByronVote bs =
     let lBs = LB.fromStrict bs
      in case Binary.decodeFull lBs of

cardano-api/src/Cardano/Api/LedgerState.hs

@@ -11,8 +11,6 @@
 {-# LANGUAGE TypeApplications #-}
 {-# LANGUAGE TypeOperators #-}
 
-{- HLINT ignore "Redundant fmap" -}
-
 module Cardano.Api.LedgerState
   ( -- * Initialization / Accumulation
     envSecurityParam
@@ -996,8 +994,6 @@ extractHistory historySeq =
 getBlockNo :: WithOrigin BlockInMode -> BlockNo
 getBlockNo = Consensus.withOrigin (BlockNo 0) (blockNo . toConsensusBlock)
 
-{- HLINT ignore chainSyncClientPipelinedWithLedgerState "Use fmap" -}
-
 -- | A history of k (security parameter) recent ledger states. The head is the
 -- most recent item. Elements are:
 --

cardano-api/src/Cardano/Api/Network/IPC/Internal/Monad.hs

@@ -24,9 +24,6 @@ import Control.Monad.IO.Class
 import Control.Monad.Reader
 import Control.Monad.Trans.Cont
 
-{- HLINT ignore "Use const" -}
-{- HLINT ignore "Use let" -}
-
 -- | Monadic type for constructing local state query expressions.
 --
 -- Use 'queryExpr' in a do block to construct queries of this type and convert

cardano-api/src/Cardano/Api/Plutus/Internal/Script.hs

@@ -15,9 +15,6 @@
 {-# LANGUAGE TypeOperators #-}
 {-# LANGUAGE UndecidableInstances #-}
 
-{- HLINT ignore "Avoid lambda using `infix`" -}
-{- HLINT ignore "Use section" -}
-
 module Cardano.Api.Plutus.Internal.Script
   ( -- * Languages
     SimpleScript'

cardano-api/src/Cardano/Api/ProtocolParameters.hs

@@ -20,8 +20,6 @@
 {-# OPTIONS_GHC -Wno-orphans #-}
 {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-}
 
-{-# HLINT ignore "Redundant ==" #-}
-
 -- | The various Cardano protocol parameters, including:
 --
 -- * the current values of updatable protocol parameters: 'ProtocolParameters'

cardano-api/src/Cardano/Api/Tx/Internal/Body/Lens.hs

@@ -1,8 +1,6 @@
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE RankNTypes #-}
 
-{- HLINT ignore "Eta reduce" -}
-
 module Cardano.Api.Tx.Internal.Body.Lens
   ( -- * Types
     LedgerTxBody (..)