(Optionally) pass server name in the access key

[notpushkin]

So that it's easier for users with multiple servers added to keep up. For example, the access key like this:

ss://[snip]@136.244.94.86:4150/?outline=1&outline_name=My+example+server

could result in a server with name My example server to be added.

The way recommended by Shadowsocks is using #my-server-name fragment, but this looks more fragile – e. g. what should this do for Unicode names or at least names with spaces in it? Maybe there's another SIP dedicated to this?

[oplexz]

#my-server-name does work, and Outline Client (at least the iOS one) already replaces the default name upon importing. I'd love to see some kind of setting that allows setting the server name in the invitation, too.

[notpushkin]

@oplexz Yeah, seems to work for me on macOS and Android as well.

I think the way to solve this then is:

• store server name on the server itself, as well as a boolean flag indicating whether we want to share it
• add it to the ProxyParams interface
• in shadowbox/server/manager_service.ts, pass it to makeConfig() as a tag so that it is added to accessUrl (which Outline Manager then inserts into the invitation template).

[maddyhof]

The invitation flow itself is no longer supported for security reasons. But on the access key itself you can supply a name, as @oplexz mentioned. But we can save this issue as a feature request for more robust support for this capability, along the lines of what @notpushkin recommends.