-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Since we're starting to maintain this again (for use in CompatHelper and eventually TagBot too), there are a couple of things that I would like:
- - Solve Throw custom exceptions instead of returning Result #12; I really dislike the
Response{T}
design pattern that I used (c6bbc7b does this but I never got it into master for whatever reason) - - Clean up pagination: I think it would be nice if pagination were handled more automatically, e.g. instead of explicitly calling
@paginate
, we return a lazy paginator by default. The logic of the pagination itself can probably be cleaned up too. (Add Iterator Traits to Paginator #18, Needs example of using paginate, and explination that it is required #17) - - Move from JSON2 to JSON3 (JSON2 is unmaintained AFAIK)
- - Tests: BrokenRecord is a good fit for testing this package.
- - Refactor endpoint definition API? I quite like what I did with Discord.jl, but this isn't really necessary and would be strictly internal so it could happen at any time. The implementation is also super messy so maybe it ought to be factored out into an external package.
oxinabox, DilumAluthge, mattBrzezinski and fchorney
Metadata
Metadata
Assignees
Labels
No labels