Skip to content

Repeating knob names in Saturator #7921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anytizer opened this issue Jun 1, 2025 · 3 comments
Open

Repeating knob names in Saturator #7921

anytizer opened this issue Jun 1, 2025 · 3 comments

Comments

@anytizer
Copy link
Contributor

anytizer commented Jun 1, 2025

Image
Are the repeating knob names ok? Lowpass, Highpass.
FX > Add: saturator.

@michaelgregorius
Copy link
Contributor

The LADSPA dialog only presents the names as defined in the plugins. So this would need to be fixed upstream in the veal repository as the plugin already defines the names for the pre and post filters in an ambiguous and non-informative way:

    { 20000,      10,           20000, 0,  PF_FLOAT | PF_SCALE_LOG | PF_CTL_KNOB | PF_UNIT_HZ, NULL, "lp_pre_freq", "Lowpass" },
    { 10,         10,           20000, 0,  PF_FLOAT | PF_SCALE_LOG | PF_CTL_KNOB | PF_UNIT_HZ, NULL, "hp_pre_freq", "Highpass" },

    { 20000,      10,           20000, 0,  PF_FLOAT | PF_SCALE_LOG | PF_CTL_KNOB | PF_UNIT_HZ, NULL, "lp_post_freq", "Lowpass" },
    { 10,         10,           20000, 0,  PF_FLOAT | PF_SCALE_LOG | PF_CTL_KNOB | PF_UNIT_HZ, NULL, "hp_post_freq", "Highpass" },

https://github.com/LMMS/veal/blob/789d0faf9faed430f48dfb93cf74e04afe88e39f/src/metadata.cpp#L1261-L1283

@anytizer
Copy link
Contributor Author

anytizer commented Jun 5, 2025

What should the new label names be? Any suggestions?
Prepend "Pre" and "Post" to the names, for making them unique?

@michaelgregorius
Copy link
Contributor

Perhaps something like "Pre Lowpass (Hz)" and "Pre Highpass (Hz)", etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants