From e77c30f68f393a41673a06e686bfc55d3f8ab04f Mon Sep 17 00:00:00 2001 From: Manda Chasteen Date: Thu, 29 Jun 2023 23:43:21 -0600 Subject: [PATCH] Units of adv_coefs? MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I've been trying to track units through the dynamics procedure in mpas_atm_time_integration and have found it difficult as several of the units for variables in the Registry are set to unitless when they apparently aren't. The units for adv_coefs and adv_coefs_3rd are a great example of ambiguous units, which––assuming that they are unitless––leads to terms in the tend_w calculation that cannot be added owing to differing units. Having dug through the code, it would seem that the units of these terms must be m^3 since they are multiplied by dcEdge**2 and dvEdge in mpas_atm_core.F. However, I am not confident about this, so I've included it as a separate pull request from my other suggested corrections about units. --- src/core_atmosphere/Registry.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core_atmosphere/Registry.xml b/src/core_atmosphere/Registry.xml index c01e9e3db7..0a6a8e9c9c 100644 --- a/src/core_atmosphere/Registry.xml +++ b/src/core_atmosphere/Registry.xml @@ -1404,10 +1404,10 @@ - -