Skip to content

Allow certain lints in .fixed compile test #243

@xFrednet

Description

@xFrednet

Compiletest currently automatically allows all unused lints in the CompileFail and Ui modes. However, this doesn't extend to .fixed files, which are used inside Clippy. For this reason, we still have a bunch of #[allow()] attributes. To avoid this, it would be nice to have an option to allow lints inside .fixed compilation tests.

In a related discussion, we agreed that it would also be cool, if we could be more specific than just allowing all lint's inside the unused group. I would suggest adding a new configuration with an enum like this:

pub enum LintConfiguration {
    /// No lints are automatically allowed
    None,
    /// All lints inside the `unused` lint group are allowed
    UnusedLints,
    /// List of lints that should be allowed. The names should be
    /// provided in the console format using dashes
    SpecificLints(&[&str])
}

I would be happy to work on this. Any feedback regarding the implementation are also welcome!

Should I work on the upstream version or in this repo? 🙃

Inspired by rust-lang/rust-clippy#7611.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions