Skip to content

Chap 8: Incorporating React Markdown  #149

@khanhtran94

Description

@khanhtran94

I think you not pass param login from UserRepositories to RepoMenu component
Readme not render because login undefined

import Fetch from "./Fetch";
import RepoMenu from "./RepoMenu";

export default function UserRepositories({
  login,
  selectedRepo,
  onSelect = f => f
}) {
  return (
    <Fetch
      uri={`https://api.github.com/users/${login}/repos`}
      renderSuccess={({ data }) => (
        <RepoMenu
          login={login}
          repositories={data}
          selectedRepo={selectedRepo}
          onSelect={onSelect}
        />
      )}
    />
  );
}

In RepositoryReadme, useEffect check !login, loadReadme will never run

 useEffect(() => {
    if (!repo || !login) {
      return;
    }
    loadReadme(login, repo).catch(setError);

  }, [repo]);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions