✨ Normalize & Rewrite #14
Conversation
# Conflicts: # Sources/Luminare/Components/Color Picker/LuminareColorPicker.swift
- `LuminareTabItem.icon` → `LuminareTabItem.image` - `LuminareTabItem.iconView()` → `LuminareTabItem.imageView()` - Removed `Hashable` implementation - Removed `Identifiable` type constraint
|
Just checking in, KrLite, how far are you away from your rewrite/what's needed for it to be 99-100%? I've been able to make a few things with it, and it's looking stable, but i see you make a few updates a day to some comps etc. |
It is actually completed and I am not planning to add any new features. The recent commits are more like hotfixes for bugs I've found during use, and there might be more to discover, but they are more like a maintenance routine. So it's ready to ship! The only thing left to do is the DocC documentation. I don't think I'm good at maintaining it :( |
|
After all, I think I will keep this fork active even after merge, since I can fix things now and then before contributing to the origin. It's just more convenient as many of my ongoing apps are referencing this fork. |
… to `isHovering`, and fix `LuminareSlider` and `LuminareSliderPicker`.
- Remove `LuminareCompactLayout` - Create `LuminareSliderLayout` and `LuminareSliderPickerLayout` - Update `LuminareSlider` and `LuminareSliderPicker` to have customizable behaviors around the text box - Move popup APIs from `LuminarePopup` to `LuminarePopupModifier` - Move and rename some files
|
Is this PR going to be merged in? |
|
@guppy57 yes! But since it's a massive PR, it's been taking some time to review, as I've been quite busy lately as well. However, I can say that this PR is looking really good and that it won't be much longer until it is merged :) |
|
@MrKai77 sounds good I totally understand, I was just wondering because I'm working on a mac app using Luminare and saw that there was an issue of not being able to submit to the app store and that this PR was hopefully going to fix that. I use loop so I'm a big fan of this library! I'm very new to swiftui but if there's anything I can do to help, let me know! |
|
While this pull request may contain a fix for the issue you mentioned, but that’s not the goal. In brief, this pull request almost rewrote the whole library. So if you want to get prepared for the breaking changes made by this pull request, I suggest you have a look at the fork to get a little bit familiar with the new APIs in advance. |
|
@KrLite Thank you for clarifying, I'll review the fork. Thank you for all the work you put into this! |
Reviewed Changes
LuminareStepperLuminareCompactPickerLuminareModalViewLuminareModalWindowLuminarePopupLuminarePopoverLuminareListLuminareColorPickerand related views... too many changes. May be filled gradually while reviewing.