feat: Allow discontiguous inputs to the group_rms_norm. #4982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When input tensors are outputs of a split operation, the stride size along the batch dimension mismatches the size of dimension. For example: a, b = c.split([size_a, size_b], dim=1) c.shape[1] = size_a + size_b a.stride = (c.shape[1], 1); a_normed.stride = (size_a, 1) b.stride = (c.shape[1], 1); b_normed.stride = (size_b, 1) This PR adds support for the above case. Note that last dimension of all inputs must be discontiguous. Signed-off-by: Simeng Liu <[email protected]>
|
/bot run --disable-fail-fast |
|
PR_Github #7860 [ run ] triggered by Bot |
|
PR_Github #7860 [ run ] completed with state |
Signed-off-by: kduan <[email protected]>
|
/bot run --disable-fail-fast |
|
PR_Github #8172 [ run ] triggered by Bot |
|
PR_Github #8172 [ run ] completed with state |
|
Both failures from the pipeline are known issues. We can proceed with skip. |
|
/bot run --disable-fail-fast |
|
PR_Github #8386 [ run ] triggered by Bot |
|
PR_Github #8386 [ run ] completed with state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Allow discontiguous inputs to the group_rms_norm.
Description
When input tensors are outputs of a split operation, the stride size along the batch dimension mismatches the size of dimension.
For example:
This PR adds support for the above case. Note that last dimension of all inputs must be discontiguous.
Test Coverage
tests/unittest/_torch/test_group_rms_norm.py::test_group_rms_norm_with_different_IO_strides