Skip to content

Use NVIDIA_CDI_HOOK_PATH instead of NVIDIA_CTK_PATH #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elezar opened this issue Nov 28, 2024 · 0 comments · Fixed by #387 · May be fixed by #212
Closed

Use NVIDIA_CDI_HOOK_PATH instead of NVIDIA_CTK_PATH #210

elezar opened this issue Nov 28, 2024 · 0 comments · Fixed by #387 · May be fixed by #212
Assignees
Labels
config issue/PR about user-facing configuration interface

Comments

@elezar
Copy link
Member

elezar commented Nov 28, 2024

Instead of relying on the nvidia-ctk binary as the hook implementation, we should move to using nvidia-cdi-hook. This only implements the required CDI hooks.

We would need to:

  • Use the NVIDIA_CDI_HOOK_PATH envvar
  • Rename / replace the helm option
  • Rename local references

Note that we already use WithNVIDIACDIHookPath when instantiating the nvcdi library instance: https://github.com/NVIDIA/k8s-dra-driver/blob/32805fec62d6b3269e75ddb0eddeaa5c4d214564/cmd/nvidia-dra-plugin/cdi.go#L106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config issue/PR about user-facing configuration interface
Projects
None yet
2 participants