Instrument SELFDESTRUCT gas func #490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaRogachev
commented
Jul 18, 2025
| @@ -517,26 +517,27 @@ func gasStaticCall(evm *EVM, contract *Contract, stack *Stack, mem *Memory, memo | |||
| } | |||
|
|
|||
| func gasSelfdestruct(evm *EVM, contract *Contract, stack *Stack, mem *Memory, memorySize uint64) (*multigas.MultiGas, uint64, error) { | |||
There was a problem hiding this comment.
params.SelfdestructGasEIP150 -> StorageAccess
params.CreateBySelfdestructGas -> StorageGrowth
MishkaRogachev
commented
Jul 18, 2025
| @@ -133,7 +133,9 @@ func gasSelfdestructEIP4762(evm *EVM, contract *Contract, stack *Stack, mem *Mem | |||
| statelessGas += evm.AccessEvents.BasicDataGas(beneficiaryAddr, true) | |||
| } | |||
| } | |||
| return multigas.ZeroGas(), statelessGas, nil | |||
| multiGas := multigas.StorageAccessGas(statelessGas) | |||
There was a problem hiding this comment.
Verkle/Stateless mode -> StorageAccess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NIT-3485
Instrument SELFDESTRUCT opcode with multigas calculations:
gasSelfdestructfuncmakeSelfdestructGasFnfor EIP-2929 and EIP-3529gasSelfdestructEIP4762for EIP-4762 (Verkle trees)