[Bug]: Puppet 8 introduced a regex node definition regression

[binford2k]

Is this a critical security issue?

• This is not a security issue.

Describe the Bug

We have node definitions of the form node /^thing-(foo|bar)(?:-test)?-(\d+)/, the backreferences in which are known to trigger puppetlabs/puppet#9329 in Puppet 7. We thought we'd take a look at Puppet 8 and see if that behavior has changed. However it seems that this pattern doesn't work at all in Puppet 8:

ERROR [qtp437212910-1916] [puppetserver] Puppet Server Error: Cannot find definition Node on node thing-foo-0.example.com

See puppetlabs/puppet#9538 for more information

It looks like the regression was introduced in https://github.com/openvox/puppet/commit/5d09d7f19ab7c68e1bc4b0df88dc1231684548b3

Expected Behavior

regex should work, or it should be documented why it does not work.

Steps to Reproduce

Create a complex regex node definition

Environment

Puppet/OpenVox 8.x+

Additional Context

No response

Relevant log output

[jstange]

We just gave this a whirl with OpenVox 8.8.1 and the behavior is still present. Backing out that LOOKAROUND_OPERATORS stuff in Puppet::Resource::Type#name fixes it, as it does with PuppetLabs' 8.7.0. I have no new insights to add, beyond what I put in the original issue (puppetlabs/puppet#9538).

We haven't tried any of the newer Puppet Labs releases, the new delivery structure being more of a hassle than is worth our while.

[ltning]

It feels like this should be a pretty simple point-release fix, and it breaks a lot of stuff for us. I can confirm backing out the mentioned change works, so we'll be doing that for now.

Pwease? :)

[ltning]

Ahem. Sorry, this was meant for the original Puppet ticket.