[tutorials] Remoive reference to unknown headers in iros11

[SunBlack]

I did not tried to compile it as I don't see any find_package call within CMake, but this tutorial includes following headers:

• solution/feature_estimation.h
• solution/filters.h
• solution/object_recognition.h
• solution/registration.h
• solution/segmentation.h

It sounds like solution is an alias for a unknown pcl path. But as nobody worried until now about this: Can this tutorial code be removed?

[aPonza]

They are local includes (so if you look at the folder structure they're there) see edit. What's really bothering in the tutorials are pcl::MovingLeastSquares::reconstruct which doesn't exist, as does pcl/surface/marching_cubes_greedy.h (unless someone still has a copy of the SVN repo to check if it was lost there somewhere) and some other minor things.

I was going to discuss this in the upcoming "[doc] from clang-doxy" PR :)

This is what I still have to fix to finish the PR

error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:27:24: error: no viable conversion from 'shared_ptr<KdTreeFLANN<pcl::PointXYZRGB, flann::L2_Simple<float> >>' to 'const shared_ptr<pcl::search::Search<PointXYZRGB>>' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:36:7: error: no member named 'reconstruct' in 'pcl::MovingLeastSquares<pcl::PointXYZRGB, pcl::Normal>' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:41:1: error: unknown type name 'SurfaceElementsPtr' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:45:24: error: no viable conversion from 'shared_ptr<KdTreeFLANN<pcl::PointXYZRGB, flann::L2_Simple<float> >>' to 'const shared_ptr<pcl::search::Search<PointXYZRGB>>' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:55:7: error: no member named 'setOutputNormals' in 'pcl::MovingLeastSquares<pcl::PointXYZRGB, pcl::Normal>' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:56:7: error: no member named 'reconstruct' in 'pcl::MovingLeastSquares<pcl::PointXYZRGB, pcl::Normal>' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:58:3: error: unknown type name 'SurfaceElementsPtr' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:58:35: error: unknown type name 'SurfaceElements' [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:127:2: error: expected ';' at end of declaration [clang]
error: /pcl/doc/tutorials/content/sources/iccv2011/include/surface.h:127:2: error: expected '}' [clang]

error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/object_recognition.h:5:10: fatal error: 'solution/filters.h' file not found [clang]

error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:27:24: error: no viable conversion from 'shared_ptr<KdTreeFLANN<pcl::PointXYZRGB, flann::L2_Simple<float> >>' to 'const shared_ptr<pcl::search::Search<PointXYZRGB>>' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:36:7: error: no member named 'reconstruct' in 'pcl::MovingLeastSquares<pcl::PointXYZRGB, pcl::Normal>' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:41:1: error: unknown type name 'SurfaceElementsPtr' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:45:24: error: no viable conversion from 'shared_ptr<KdTreeFLANN<pcl::PointXYZRGB, flann::L2_Simple<float> >>' to 'const shared_ptr<pcl::search::Search<PointXYZRGB>>' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:55:7: error: no member named 'setOutputNormals' in 'pcl::MovingLeastSquares<pcl::PointXYZRGB, pcl::Normal>' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:56:7: error: no member named 'reconstruct' in 'pcl::MovingLeastSquares<pcl::PointXYZRGB, pcl::Normal>' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:58:3: error: unknown type name 'SurfaceElementsPtr' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:58:35: error: unknown type name 'SurfaceElements' [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:127:2: error: expected ';' at end of declaration [clang]
error: /pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h:127:2: error: expected '}' [clang]
error: /pcl/doc/tutorials/content/sources/qt_colorize_cloud/pclviewer.h:4:10: fatal error: 'QMainWindow' file not found [clang]
error: /pcl/doc/tutorials/content/sources/qt_visualizer/pclviewer.h:6:10: fatal error: 'QMainWindow' file not found [clang]

EDIT: or not, I actually solved this with this diff

diff --git a/doc/tutorials/content/sources/iros2011/include/solution/object_recognition.h b/doc/tutorials/content/sources/iros2011/include/solution/object_recognition.h
index 9525fdcc3..b7bcd01bb 100644
--- a/doc/tutorials/content/sources/iros2011/include/solution/object_recognition.h
+++ b/doc/tutorials/content/sources/iros2011/include/solution/object_recognition.h
@@ -1,11 +1,11 @@
 #pragma once
 
-#include "typedefs.h"
-#include "load_clouds.h"
-#include "solution/filters.h"
-#include "solution/segmentation.h"
-#include "solution/feature_estimation.h"
-#include "solution/registration.h"
+#include <typedefs.h>
+#include "../load_clouds.h"
+#include <filters.h>
+#include <segmentation.h>
+#include <feature_estimation.h>
+#include <registration.h>
 
 #include <pcl/io/pcd_io.h>
 #include <pcl/kdtree/kdtree_flann.h>

LAST EDIT: but maybe it's not correct yet, as they're both in include/ and in include/solutions/ (see path)

[stale]

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.