Bump to Node 22.15.1 and removes node-fetch #5214
Conversation
Fixes #5213
There was a problem hiding this comment.
Pull Request Overview
This PR updates the extension’s supported VS Code version, bumps Node and TypeScript type dependencies, and removes the now-unnecessary node-fetch package.
- Raise
engines.vscodeto^1.101.0 - Drop
node-fetchand its type definitions in favor of Node’s built-infetch - Bump
@types/nodeto match Node v22.15.1 and update@types/vscode
Comments suppressed due to low confidence (2)
package.json:9
- Consider adding an
engines.nodefield (e.g.,"node": ">=22.15.1") to package.json to enforce the minimum Node.js runtime version required by this extension.
"vscode": "^1.101.0"
package.json:63
- Since
node-fetchhas been removed in favor of the nativefetchAPI in Node.js, consider updating the README or CHANGELOG to document this change and any migration steps for consumers.
"node-fetch": "^2.7.0"
|
@andyleejordan eslint got real mad at me for unchanged stuff, do we want to fix these or add a rules exclusion? |
| @@ -112,7 +111,7 @@ export class UpdatePowerShell { | |||
| } | |||
| // Looks like: | |||
| // { | |||
| // "ReleaseDate": "2022-10-20T22:01:38Z", | |||
| // "ReleaseDate": "2022-10-fetc20T22:01:38Z", | |||
There was a problem hiding this comment.
Almost certainly a focus fat finger I missed.
|
Ah a few things missing. This is complicated enough that I documented it here: https://github.com/PowerShell/vscode-powershell/blob/main/docs/development.md#tracking-upstream-dependencies Mostly need to be sure to cross reference everything (which I think you did) and update both pipelines. I have generally gone ahead and fixed new ESLint errors rather than suppress them when updating Node.js. |
Fixes #5213
PR Summary
Bumps to Node 22.15.1 and removes node-fetch. Requires VSCode v1.101 or higher for future extension releases.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready