Skip to content

Bug in the repo path for the binder #79

Open
@brian-rose

Description

@brian-rose

This line in the build-book.yaml workflow assumes that a PR originates from

--repo ${{ github.actor }}/$CI_REPOSITORY_NAME

and send this as input to binderbot when we need to point to the current PR branch to build a new image on the binder (because of a change in the environment file).

But this logic assumes that the PR branch is always in ${{ github.actor }}'s personal GitHub space. If someone who is a member of the ProjectPythia org opens a PR from a branch owned by the organization, it fails.

The reason it fails is because ${{ github.actor }} points to that person's user name, but the repo name is actually ProjectPythia/$CI_REPOSITORY_NAME.

An example is ProjectPythia/na-cordex-viz-cookbook#7.

Note that when you edit a file directly on GitHub it defaults to creating a new branch within the org, which is what happened in the above example.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues that present a reasonable conviction there is a reproducible bug.infrastructureInfrastructure related issue

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions