Skip to content

[clr] Use is_versioned = true consistently in both Comgr::LoadLib paths. #628

Open
@zichguan-amd

Description

@zichguan-amd

Summary

Prior to this, RTCProgram was using is_version = true and device initialization was using false. On Windows, this was causing us to attempt to load amd_comgr_3.dll at device load and amd_comgr0605.dll for RTC programs. Obviously, there is only one DLL and it must be used consistently.

Link to patch

https://github.com/ROCm/TheRock/blob/main/patches/amd-mainline/clr/0001-windows-Use-is_versioned-true-consistently-in-both-C.patch

Permalink to patch

https://github.com/ROCm/TheRock/blob/dc6114732df8ba5ae3d8e78fd9f436682d752e04/patches/amd-mainline/clr/0001-windows-Use-is_versioned-true-consistently-in-both-C.patch

PR to upstream

ROCm/clr#162

Metadata

Metadata

Assignees

Labels

patchUsed to track patches

Type

No type

Projects

Status

In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions