Table `aowow_spellrange` missed in sql dump

[unsektor]

I took fresh master branch 647be4a and tried to setup aowow from scratch (while moving #450 upon fresh changes) and got an error:

aowow-1  | 18:17:02          [build] gathering data for glyphs
aowow-1  | 18:17:02  [WARN]  WARNING - mysqli_query(): (42S02/1146): Table 'aowow.aowow_spellrange' doesn't exist @ /var/www/html/includes/libs/DbSimple/Mysqli.php:165
aowow-1  | 18:17:02  [WARN]  WARNING -  at /var/www/html/includes/components/dbtypelist.class.php line 276 @ /var/www/html/includes/database.class.php:93

while running

php ./aowow --build=glyphs

I tried to search aowow_spellrange in sql dump files, but found nothing. However related DDL exists in master-deprecated branch in setup/db_structure.sql file.

--
-- Table structure for table `aowow_spellrange`
--

DROP TABLE IF EXISTS `aowow_spellrange`;
/*!40101 SET @saved_cs_client     = @@character_set_client */;
/*!40101 SET character_set_client = utf8mb4 */;
CREATE TABLE `aowow_spellrange` (
  `id` tinyint unsigned NOT NULL,
  `rangeMinHostile` tinyint unsigned NOT NULL,
  `rangeMinFriend` tinyint unsigned NOT NULL,
  `rangeMaxHostile` mediumint unsigned NOT NULL,
  `rangeMaxFriend` mediumint unsigned NOT NULL,
  `rangeType` tinyint unsigned NOT NULL,
  `name_loc0` varchar(27) DEFAULT NULL,
  `name_loc2` varchar(27) DEFAULT NULL,
  `name_loc3` varchar(27) DEFAULT NULL,
  `name_loc4` varchar(27) DEFAULT NULL,
  `name_loc6` varchar(27) DEFAULT NULL,
  `name_loc8` varchar(27) DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
/*!40101 SET character_set_client = @saved_cs_client */;

Was this table missed or removed intentionally ?

[Sarjuuk]

Left out intentionally.
There were a couple of table definitions that get overwritten by the dbc extraction steps as these tables are literally 1:1 copies of their dbc counterpart.

The fields end up larger than they strictly need to be, but whatever.

Seems like the glyphs script is missing a dependency..?

[Sarjuuk]

So, technically $setupAfter should contain 'spellrange', but 'spell' does have 'spellrange' as a requirement, while also being a requirement for 'glyphs'.
So 'glyphs' implicitly gets slotted after 'spellrange' anyway.

Did you run a full setup or are you calling each setup script individually .. potentially out of order?

The auto sorting described is only for the setup (php aowow -s). The build scripts do not test for tables and assumed that the DB is filled and finished if they are called individually.

[unsektor]

Thank you, you are right. Indeed, I didn't invoke aowow --setup script because in my case it's required to complete application setup without user interaction (for example, without DB credentials, application settings, and answering questions on script error), instead of that I have used setup script invocations with explicit --build and --sql options respectively, and lose sight of subscripts run order.

I guess it's my mistake — this behaviour aroused suspicion because it was worked on master-deprecated branch, but not on master.

Calling

php ./aowow --sql
php ./aowow --build

instead of

php ./aowow --setup

is the solution in my case.

Therefore, if issue is not requires any change, I guess this issue could be closed.

[Sarjuuk]

yesn't...

There ist one exception to running --sql then --build.
If you don't let your TC core calculate zone data for creature and gameobject, the --build=compleximg --maps step will generate rough bitmaps from the map files, which the --sql=spawns step then uses to guesstimate spawnpoints.
You really shouldn't rely on this fallback, but it exists.

/e: also I think there was a way to avoid interactivity, but I have to check that later.