Skip to content

Not Found has status code 200 #271

@MiningTcup

Description

@MiningTcup

If I request skipSegments for a video ID which does not have an entry on my mirror, it will check Ajay's mirror. However, if Ajay's mirror returns Not Found, it will relay that to the user, but without the status code 404 (instead, 200). Not using the correct status code causes problems: For example, the SponsorBlock module of ReVanced will attempt to parse the data, but when finding Not Found instead of a JSON structure, will have an error. You can verify this by looking up the skipSegments for a video without an entry on a sponsorblock mirror vs the official website, and checking the network logs. Official website says 404, mirror says 200. Sorry for the badly written issue 💀

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions