Email newsletter: paid posts are visible to free members if posts miss `/preview`

[fkromer]

Issue Summary

Email newsletters display and deliver the full content of paid posts to free members if the blog post does not contain an explicit /preview.

https://ghost.org

Steps to Reproduce

1. Don't use /preview in paid blog post.
2. Configure paid blog post for paid members only.
3. Observe Email preview in Ghost web UI > Post > Preview > Email (Paid member: Free member).

Ghost Version

https://ghost.org

Node.js Version

https://ghost.org

How did you install Ghost?

https://ghost.org

Database type

Other

Browser & OS version

Does not matter.

Relevant log / error output

n.a.

Code of Conduct

• I agree to be friendly and polite to people in this repository

[cathysarisky]

Hey @fkromer ! This behavior is not new, and I agree it's confusing! I guess the question is, what's the desired behavior? If a post is marked paid-members-only, and you've chosen to send it to free members, what should happen?

Current behavior: Free members get a copy of the newsletter, since you selected them to get it.
Alternate behavior 1: No newsletter sent, even though you selected them? I worry about this being confusing.
Alternate behavior 2: Newsletter is sent, but since there's no paywall, all they get is the featured image*, title*, excerpt*, and CTA. (*Unless you've turned these things off in newsletter settings, in which case they might ONLY get the CTA).

I think sending nothing but a CTA is probably poor practice. So is alternate behavior 1 better/less confusing than the current behavior?

Option 3 - behavior doesn't change, but there's a warning visible that your free members are about to receive the paid newsletter.
Option 4 - if the access is set to paid members, the free button is greyed out and not-selectable.

I think I probably like option 4 best, personally. What do you think?

[fkromer]

@cathysarisky Option 5: Check for an explicit /preview in paid posts and display a warning if it's missing? Otherwise Option 4 works as well I guess.