InMemoryFileSystemProvider AppPlayground causes issues with the outline service

[ssmifi]

Using the last changes to the AppPlayground together with the outline service override throws an error every time one changes the file. The outline works though. I think this was not the case with the RegisteredFileServiceProvider.

Uncaught (in promise) Canceled: Canceled
    at Delayer.cancel (http://localhost:20001/node_modules/.vite/deps/chunk-GWAXN5OK.js?v=94d6cfb4:1273:65)
    at Delayer.dispose (http://localhost:20001/node_modules/.vite/deps/chunk-GWAXN5OK.js?v=94d6cfb4:1283:14)
    at dispose (http://localhost:20001/node_modules/.vite/deps/chunk-XX2NKZE7.js?v=94d6cfb4:2141:13)
    at _DisposableStore.clear (http://localhost:20001/node_modules/.vite/deps/chunk-XX2NKZE7.js?v=94d6cfb4:2346:11)
    at _DisposableStore.dispose (http://localhost:20001/node_modules/.vite/deps/chunk-XX2NKZE7.js?v=94d6cfb4:2336:14)
    at WorkbenchDataTree2.dispose (http://localhost:20001/node_modules/.vite/deps/chunk-7PVOOJZ7.js?v=94d6cfb4:31046:31)
    at http://localhost:20001/node_modules/.vite/deps/@codingame_monaco-vscode-outline-service-override.js?v=94d6cfb4:1363:12
    at http://localhost:20001/node_modules/.vite/deps/chunk-XX2NKZE7.js?v=94d6cfb4:2175:7
    at Object.dispose (http://localhost:20001/node_modules/.vite/deps/chunk-XX2NKZE7.js?v=94d6cfb4:1937:19)
    at dispose (http://localhost:20001/node_modules/.vite/deps/chunk-XX2NKZE7.js?v=94d6cfb4:2141:13)

Test branch in #936

[kaisalmen]

@CGNonofr this also happens in the mva demo. I just checked. Do you have any idea what goes wrong?

[CGNonofr]

I'm not sure how to reproduce 🤔 can you give an exact scenario?

btw, there are some places in the vscode code where errors are not handled, and the error can be the task being cancelled... I'm afraid there is nothing to do as it also happens in VSCode itself (except patching vscode of course)

[kaisalmen]

I'm not sure how to reproduce 🤔 can you give an exact scenario?

The outline view must be used/be visible. That's all.

[CGNonofr]

Oh, by changing file, you mean opening another file!

[kaisalmen]

Oh, by changing file, you mean opening another file!

yes, just open any file when the Outline is visible. It happens ervery time

[CGNonofr]

I'm afraid it comes from the VSCode repository, I'm not sure why I'm not able to reproduce it with VScode.dev, by the source is easy to find

the trigger method is called without the returned promise error being handled

Feel free to open a PR or an issue on the VSCode side :)

[kaisalmen]

@CGNonofr thank you for your feedback. I checked the Developer Tools console in Desktop VSCode and can't see the error, either.

[kaisalmen]

@CGNonofr because we can't reproduce this with VSCode Web or Desktop. Is there any way to intercept this or centrally catch such errors and delegate them to a configurable error handler? I have heard about this leading to nasty errors/re-redenders, but I can't reproduce this behaviour myself.

[CGNonofr]

@CGNonofr because we can't reproduce this with VSCode Web or Desktop. Is there any way to intercept this or centrally catch such errors and delegate them to a configurable error handler? I have heard about this leading to nasty errors/re-redenders, but I can't reproduce this behaviour myself.

We have a way to patch VSCode before importing from it. Feel free to create a PR with the patch, but then it's probably a good idea to also create a PR on the VSCode side

[kaisalmen]

We have a way to patch VSCode before importing from it. Feel free to create a PR with the patch, but then it's probably a good idea to also create a PR on the VSCode side

Yes, thank you, good idea. I didn't get to it, yet and the next couple of days are blocked. We'll see.

Is it done like described in the last bullet here? In the case of a bug fix we are already on correct version. One fixes the bug, and then creates the patch, correct?

[CGNonofr]

Is it done like described in the last bullet here? In the case of a bug fix we are already on correct version. One fixes the bug, and then creates the patch, correct?

yes, update or not, the process to touch VSCode patches is always the same:

• checkout the correct VSCode version tag
• apply the existing patches with git am
• apply the changes, rewrite the git history, add a new commit....
• regenerate the patches with git format-patch

[kaisalmen]

@ssmifi and @CGNonofr I forgot about this issue. Did you find a way we can reproduce this in VSCode Web or Desktop version? I haven't found one so far (at least in July). Otherwise, it makes no sense to open a PR in the VSCode repo.

[CGNonofr]

I've fixed a similar error though, maybe this exact one

[kaisalmen]

Was it this one?
CodinGame/monaco-vscode-api@6a0a15a#diff-d724eb88b4195629857fbbf820480905f0d1e63ed003144c1096eafa29bf175d

[CGNonofr]

Was it this one? CodinGame/monaco-vscode-api@6a0a15a#diff-d724eb88b4195629857fbbf820480905f0d1e63ed003144c1096eafa29bf175d

Very likely :)