PHP 8.5: Prevent deprecation notices for curl_close

TobiasBg · web-flow · commit d231e9dd19d3 · 2025-09-01T16:48:22.000+02:00
`curl_close` is deprecated in PHP 8.5+, and hasn't been doing anything since PHP 8.0. To prevent deprecation warnings it should therefore be called on older versions of PHP only. See https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_no-op_functions_from_the_resource_to_object_conversion.
diff --git a/tests/Utility/InputValidator/IsCurlHandleTest.php b/tests/Utility/InputValidator/IsCurlHandleTest.php
@@ -22,7 +22,7 @@ final class IsCurlHandleTest extends TestCase {
 	 * Clean up after the tests.
 	 */
 	public static function tear_down_after_test() {
-		if (isset(self::$curl_handle) && is_resource(self::$curl_handle)) {
+		if (isset(self::$curl_handle) && is_resource(self::$curl_handle) && \PHP_VERSION_ID < 80000) {
 			curl_close(self::$curl_handle);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ final class IsCurlHandleTest extends TestCase {`
`22`	`22`	`* Clean up after the tests.`
`23`	`23`	`*/`
`24`	`24`	`public static function tear_down_after_test() {`
`25`		`- if (isset(self::$curl_handle) && is_resource(self::$curl_handle)) {`
	`25`	`+ if (isset(self::$curl_handle) && is_resource(self::$curl_handle) && \PHP_VERSION_ID < 80000) {`
`26`	`26`	`curl_close(self::$curl_handle);`
`27`	`27`	`}`
`28`	`28`