Skip to content

Look into skipping runtime validation of the AceConfig options table #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdw-software opened this issue Mar 2, 2025 · 0 comments
Open

Comments

@rdw-software
Copy link
Member

The high-level API doesn't expose this, but it may be possible to skip the validation when initially creating Rarity's options UI:

https://github.com/WoWUIDev/Ace3/blob/cbebdf878fed0d6e0a56bbe9d11f065d26b323bb/AceConfig-3.0/AceConfigRegistry-3.0/AceConfigRegistry-3.0.lua#L316

In theory this is a cost that needn't be paid on load: Validation can just as easily be performed offline (as part of the test suite).
I don't know if this is really significant, but it's worth considering. The options module may benefit from some restructuring, as it is.

One possible caveat: If custom items need to be validated, they wouldn't be covered. But at first glance, it doesn't look like that matters (?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Soon™
Development

No branches or pull requests

1 participant