Skip to content

Investigate 11.1.5 TOC settings to preload saved variables #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdw-software opened this issue Mar 8, 2025 · 0 comments
Open

Investigate 11.1.5 TOC settings to preload saved variables #850

rdw-software opened this issue Mar 8, 2025 · 0 comments

Comments

@rdw-software
Copy link
Member

rdw-software commented Mar 8, 2025

In 11.1.5, there are more ways to control the order of loading saved variables (you can load them before the addon itself is run) 1. As far as I'm aware, this is mostly handled by AceAddon and the event-based initialization right now. However, there are some potential issues which could be alleviated by streamlining the load order (important caveat: Treading careful here is mandatory as overwriting the saved variables would erase all data).

  • Some users have reported errors where the DB wasn't available in time, causing errors. This has been fairly rare but it does happen; it's a typical symptom of async/interleaved code paths and should in theory be fixed if the load order is guaranteed to be sequential by the client
  • In the code, there are some timers seemingly used to retry initializing the Options when AceDB hasn't loaded - could then remove these
  • It'll be much easier to test that things are loading as expected; including the DB initialization and DB migrations (if implemented)
  • Some of the initialization code could potentially be simplified, removed, or dependencies dropped - less code means reduced costs overall
  • There have been difficult-to-reproduce issues with default values not being loaded as expected - another problem that may be avoided

Footnotes

  1. https://warcraft.wiki.gg/wiki/Patch_11.1.5/API_changes

@rdw-software rdw-software added this to the TWW Content Updates milestone Mar 8, 2025
@rdw-software rdw-software moved this to Soon™ in Rarity Mar 8, 2025
@rdw-software rdw-software moved this from Soon™ to The time is nigh (Planning) in Rarity Mar 8, 2025
@rdw-software rdw-software changed the title Investigate 11.5 TOC settings to preload saved variables Investigate 11.1.5 TOC settings to preload saved variables May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: The time is nigh (Planning)
Development

No branches or pull requests

1 participant