[Statistics/Dashboard] Demographic counts are inconsistent

[johnsaigle]

Describe the bug
The count for Female and Male participants do not match. The dashboard demographic numbers are different from the Demographic Statistics tab.

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

1. Go to demo.loris.ca and compare the counts.

What did you expect to happen?
The numbers should be the same.

[johnsaigle]

The two locations in the code use different queries:

e.g.

Loris/modules/statistics/php/module.class.inc

Lines 268 to 277 in 6190c99

	private function _getTotalSex(\Database $db, string $sex) : int
	{
	return $db->pselectOne(
	"SELECT COUNT(c.CandID)
	FROM candidate c
	WHERE c.Sex=:sex AND c.Active='Y' AND c.Entity_type='Human'
	AND c.RegistrationCenterID <> 1",
	array('sex' => $sex)
	);
	}

Loris/modules/statistics/php/stats_demographic.class.inc

Lines 347 to 367 in 6190c99

	//MALE
	$result = $db->pselect(
	"SELECT s.subprojectid as rowid,
	count(DISTINCT(c.PSCID)) as val
	FROM candidate as c
	LEFT JOIN participant_status ps ON (ps.CandID=c.CandID)
	LEFT JOIN session s ON (s.CandID=c.CandID)
	WHERE coalesce(s.active, 'Y')='Y'
	AND c.RegistrationCenterID <> '1'
	AND s.CenterID <> '1'
	AND s.CenterID IN (" . $sitesString . ")
	AND c.Entity_type != 'Scanner'
	AND c.Active='Y'
	AND (ps.participant_status=1 OR
	ps.participant_status IS NULL)
	AND c.Sex='Male'
	$paramProject
	$paramSite
	GROUP BY s.subprojectid",
	$this->params ?? array()
	);

I'm not sure which one should be adjusted but to me the Widget code looks more straightforward. I'm not sure why all the JOINs are needed in the stats module.

Could someone else weigh in?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.