Skip to content

[NDB_BVL_Instrument_LINST] Change Examiner type to enum #9873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: 27.0-release
Choose a base branch
from
Open

[NDB_BVL_Instrument_LINST] Change Examiner type to enum #9873

wants to merge 5 commits into from

Conversation

jeffersoncasimir
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir commented Jun 18, 2025 •
edited
Loading

Closes #9852

All examiners are returned for the data dictionary when empty($this->getCommentID()).

@driusan Are there any permissions concerns with returning all Examiners?

@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Jun 18, 2025
kongtiaowang
kongtiaowang approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees

@kongtiaowang kongtiaowang

Labels
Language: PHP PR or issue that update PHP code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffersoncasimir @kongtiaowang