[redcap] Delete IRedcapRecord
#9913
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeBICMTL
added
Difficulty: Simple
|
imu (which stands for 'in my understanding'). You have:
correct? or... because if correct, then I approve. |
regisoc
approved these changes
Jul 16, 2025
The renaming is rather unrelated to the deletion but that's the idea yes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current class hierarchy is
RedcapRepeatingRecord extends RedcapRecord implements IRedcapRecord. I believe this is overcomplicated and we should only be a singleRedcapRecordclass, this PR is a step in that direction.Changelog
IRedcapRecordinterface (which is currently kind of useless since it is directly inherited by a single class).RedcapRecord->getInstrumentName()toRedcapRecord->getLorisInstrumentName()(as it is the name of the instrument in LORIS, which may be different from the name in REDCap for repeating instruments).