[redcap] Fix record field name implicit int conversion
#9915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeBICMTL
added
Category: Bug
MaximeBICMTL
changed the title
int conversion.int conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have an instrument with some integer-like field names in REDCap ("0" / "1"), this caused a type error in
RedcapNotificationHandlerwith "stringexpected,intgiven". After investigating a bit, REDCap correctly sends the field namesas strings but it turns out that PHP implicitly converts array keys to integers if they look like integers.Changelog
strvalin the regex matching where the field name is required to be a string._formatEnumFieldsslightly less unreadable by using aforeachinstead ofarray_keys/array_reduce.