Skip to content

Commit 93636cf

Browse files
committed
Skip existing Sign users that are excluded
1 parent 6feaa80 commit 93636cf

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

user_sync/engine/sign.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,11 @@ def update_sign_users(self, directory_users, sign_connector: SignConnector, org_
153153
"""
154154
# Fetch the list of active Sign users
155155
sign_user_groups = sign_connector.get_user_groups()
156-
filtered_users = {user.email: user for user in sign_connector.get_users().values() if not self.sign_user_excluded(user, sign_user_groups[user.id], sign_connector)}
156+
all_users = sign_connector.get_users().values()
157+
filtered_users = {user.email: user for user in all_users if not self.sign_user_excluded(user, sign_user_groups[user.id], sign_connector)}
157158
sign_users = {user.email: user for user in filtered_users.values() if user.status != 'INACTIVE'}
158159
inactive_sign_users = {user.email: user for user in filtered_users.values() if user.status == 'INACTIVE'}
160+
self.excluded_users = {user.email: user for user in all_users if self.sign_user_excluded(user, sign_user_groups[user.id], sign_connector)}
159161
self.sign_user_primary_groups[org_name] = {id: [g for g in groups if g.isPrimaryGroup][0] for id, groups in sign_user_groups.items()}
160162
users_update_list = []
161163
user_groups_update_list = []
@@ -175,6 +177,9 @@ def update_sign_users(self, directory_users, sign_connector: SignConnector, org_
175177
assignment_group = self.default_groups[org_name].groupName
176178
user_roles = self.retrieve_admin_role(directory_user)
177179
if sign_user is None:
180+
if directory_user['email'] in self.excluded_users:
181+
self.logger.debug("(%s) Found excluded user %s directory user list, skipping", org_name, directory_user['email'])
182+
continue
178183
if sign_connector.create_users:
179184
inactive_user = inactive_sign_users.get(directory_user_key)
180185
# if Standalone user is inactive, we need to reactivate instead of trying to create new account

0 commit comments

Comments
 (0)