Suggestion: supertest-as-promised for unit tests.

[gintsgints]

This project:

https://www.npmjs.org/package/supertest-as-promised

allows to use promises instead of putting calls inside calls for tests. May be it is worth to take look.

[JaKXz]

@gintsgints if you could propose a PR that'd be awesome.

[kingcody]

@gintsgints being that you have a working fork now, I was wondering if you would be able to take a look at the tests in canary in particular the ones using supertest.

[gintsgints]

I had to delete my own made fork, because github support try to solve my forking problems. But I can try to take a look to canary.

[gintsgints]

Oki github solved my problem. Fork created now. Do you use different as-promised package?

[gintsgints]

canary branch tests fails for me. Says lot of unexpected files.

[kingcody]

In test/test-file-creation.js there is a function called genFiles it is used to generate an array of expected files. Are the unexpected files new to the project? If so you'll need to add them to the genFiles function.

[gintsgints]

Tests fails on files that are in genFiles array.

2014-09-26 17:50 GMT+03:00 Cody Mize notifications@github.com:

In test/test-file-creation.js there is a function called genFiles it is
used to generate an array of expected files. Are the unexpected files new
to the project? If so you'll need to add them to the genFiles function.

—
Reply to this email directly or view it on GitHub
#544 (comment)
.

Ginc

[kingcody]

Odd, could you post a link to your logs?

[gintsgints]

https://gist.github.com/gintsgints/3356eecb7ecf46ea2b4b

[gintsgints]

seems like it recognises files in root (at least last test) as example .bowerrc. But not files inside directory. (list variable is generated for all of thease files)

[gintsgints]

Realy weird. var index = files.indexOf(file); does not find kind of 'client/.htaccess' strings in array. May be somthing to do with Windows ?

[gintsgints]

@kingcody I cannot find supertest-as-promised usage in canary. Do I miss somthing?

[kingcody]

I don't think so... The tests in the server use supertest. I was under the opinion that you were looking to switch them to use supertest-as-promised.

[gintsgints]

@kingcody Yes you are correct about my intent :). But I realy cannot find supertest-as-promised usage.
Could not be that somthing from you is not pushed to server?