Bugfix DNSClient::getHostByName() #2499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valid IP address digits have to be >= 0 AND <= 9 valid IP addresses must have 4 segments
|
Thank you @jhorck . Do you mind applying your fix to branch 1.5.x? Master is the old 1.0.x series that is phasing out. 1.5.x is soon to become the new stable. On branch 1.5.x we also have a bot that packs the IDE with the proposed fix so that everyone can easily test it. Thank you in advance |
|
done: #2500 |
|
Correct, that's a secondary branch, we merge it manually with ide-1.5.x every once in a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in DNSClient::getHostByName() and fixed it.
I'm trying to connect to a local server, called 'htpc'. The hostname is resolved by DNSClient::getHostByName(). The first thing this function does is "See if it's a numeric IP address" by calling inet_aton(). It returns falsely 1 (=yes, it's a numeric IP address) for hostname 'htpc'
For most (longer) hostnames it will accidentally return 0. This is probably why it hasn't been discovered before.