Skip to content

Conversation

@erikachen19
Copy link
Contributor

@erikachen19 erikachen19 commented Jul 31, 2025

resolves #550

Description

schema needs to be removed when dropping a temporary view (file format = Parquet) and when applying the get_insert_overwrite_sql strategy

Checklist

  • I have signed the CLA

  • I have run this code in development and it appears to resolve the stated issue

  • This PR includes tests, or tests are not required/relevant for this PR

  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

@moomindani
Copy link
Collaborator

It seems that the integration test failed. Could you please fix it?

Plz ignore Python model test as it's newly added test yesterday. If you fetch the upstream change, it will start succeeding.

@moomindani moomindani added enable-functional-tests This label enable functional tests and removed enable-functional-tests This label enable functional tests labels Aug 2, 2025
@moomindani
Copy link
Collaborator

The integ test still failed. Can you make sure that your local integ test succeeded?

@erikachen19
Copy link
Contributor Author

erikachen19 commented Aug 5, 2025

Hi @moomindani,
the local integration test ran successfully.
The upstream change (support for Python model) has been fetched.
image

@moomindani
Copy link
Collaborator

moomindani commented Aug 5, 2025

Thanks. Can you clean up your PR in the diff without including the other Python model support by git rebase?

@erikachen19
Copy link
Contributor Author

erikachen19 commented Aug 5, 2025

sorry, i am afraid that i dont know how to use git rebase,
did i add extra files that i should not have had to?

would be easier if i create new feature branch from main?

@moomindani
Copy link
Collaborator

Thanks for thinking about that.

To reflect latest changes happening in the main branch, I usually do like...

  1. Switch to your branch
$ git checkout your_branch
  1. Reflect changes
$ git pull origin your_branch
  1. Rebase your PR branch onto main
$ git rebase main

If you are not familiar with the commands, it may be easier for you to use LLM like Amazon Q CLI to help this. I used Amazon Q CLI asking it and it worked pretty well.

Here's the sample prompt I used:

In this repo, I am working on PR in `your_branch` branch. As the gap between upstream and this branch became bigger, I want to reflect the latest changes to `your_branch` branch. I already updated main branch with the latest changes. How can I merge the changes without messing up the PR?

Make sure that you amend the commit before that. If making a new PR is easier for you, that will be totally fine as well.

@erikachen19 erikachen19 force-pushed the tmp_relation_glue_table branch from 26e6633 to f561039 Compare August 5, 2025 23:32
@erikachen19
Copy link
Contributor Author

Hi @moomindani,
Thank you for sharing the commands.
The PR has been cleaned up.

@moomindani moomindani added enable-functional-tests This label enable functional tests and removed enable-functional-tests This label enable functional tests labels Aug 6, 2025
@moomindani moomindani merged commit c233032 into aws-samples:main Aug 6, 2025
24 checks passed
@moomindani
Copy link
Collaborator

Thank you for your contribution! Merged.

@erikachen19
Copy link
Contributor Author

hi @moomindani ,
Thank you for your help!
Is there any plan to make a new release with those updates?

@moomindani
Copy link
Collaborator

Yes, but we still have some action items need to be addressed.

@moomindani moomindani mentioned this pull request Aug 20, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor enable-functional-tests This label enable functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[glue__make_temp_relation] Return the tmp_relation object without database and schema

2 participants