-
Notifications
You must be signed in to change notification settings - Fork 86
Fix schema removal issue from DROP VIEW and get_insert_overwrite_sql strategy #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schema removal issue from DROP VIEW and get_insert_overwrite_sql strategy #590
Conversation
|
It seems that the integration test failed. Could you please fix it? Plz ignore Python model test as it's newly added test yesterday. If you fetch the upstream change, it will start succeeding. |
|
The integ test still failed. Can you make sure that your local integ test succeeded? |
|
Hi @moomindani, |
|
Thanks. Can you clean up your PR in the diff without including the other Python model support by git rebase? |
|
sorry, i am afraid that i dont know how to use git rebase, would be easier if i create new feature branch from main? |
|
Thanks for thinking about that. To reflect latest changes happening in the main branch, I usually do like...
If you are not familiar with the commands, it may be easier for you to use LLM like Amazon Q CLI to help this. I used Amazon Q CLI asking it and it worked pretty well. Here's the sample prompt I used: Make sure that you amend the commit before that. If making a new PR is easier for you, that will be totally fine as well. |
26e6633 to
f561039
Compare
…et) or when applying the get_insert_overwrite_sql strategy
|
Hi @moomindani, |
|
Thank you for your contribution! Merged. |
|
hi @moomindani , |
|
Yes, but we still have some action items need to be addressed. |

resolves #550
Description
schema needs to be removed when dropping a temporary view (file format = Parquet) and when applying the get_insert_overwrite_sql strategy
Checklist
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have updated the
CHANGELOG.mdand added information about my change to the "dbt-glue next" section.