why is OpenedConnectionTracker not pruning closed connections?

[ivankhoosty]

https://github.com/awslabs/aws-advanced-jdbc-wrapper/blob/main/wrapper/src/main/java/software/amazon/jdbc/plugin/OpenedConnectionTracker.java#L196

I am observing a lot of connections being logged by the tracker, but most of them are actually closed. what would be the use case where someone would want to track connection objects until they are garbage collected, rather than closed?

maybe offer an option for the tracker to remove closed connections from the queue?

thanks

[ivankhoosty]

Hi @sergiyvamz , do you think this should be changed? thanks

[sergiyvamz]

Hi @ivankhoosty,

That's definitely not a perfect manner to keep closed and disposed connections in the queue. I've create an internal ticket for this and will keep you informed on the progress. Is the extra memory consumption blocking your development?

Thank you raising this issue!

[ivankhoosty]

Hi, thanks, not blocking anything, just making it difficult to keep track of open and already closed connections in the logs.

…

On Thu, 23 May 2024 at 20:35, sergiyvamz ***@***.***> wrote: Hi @ivankhoosty <https://github.com/ivankhoosty>, That's definitely not a perfect manner to keep closed and disposed connections in the queue. I've create an internal ticket for this and will keep you informed on the progress. Is the extra memory consumption blocking your development? Thank you raising this issue! — Reply to this email directly, view it on GitHub <#993 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACRJK23CBQ77DCWXA3VUTD3ZDZAI5AVCNFSM6AAAAABHYK3ZUCVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TKMZZGA2DG> . You are receiving this because you were mentioned.Message ID: <aws/aws-advanced-jdbc-wrapper/repo-discussions/993/comments/9539043@ github.com>