chore: cleanup cleanup spelling and function declarations (#815)

Author: ajewellamz

examples/kms_discovery.cpp

@@ -172,7 +172,7 @@ int main(int argc, char **argv) {
 
     /* This keyring is guaranteed to only call KMS to attempt decryptions
      * in eu-central-1, and it will only attempt to do so when it sees that
-     * the message has beeen encrypted by this specific CMK.
+     * the message has been encrypted by this specific CMK.
      */
     decryption_keyrings.push_back(Aws::Cryptosdk::KmsKeyring::Builder().Build(key_arn_eu_central_1));
 

examples/string.cpp

@@ -199,7 +199,7 @@ int main(int argc, char **argv) {
         return ret;
     }
 
-    /* We need to intialize the AWS SDK for C++ when we use the C++ KMS keyring. */
+    /* We need to initialize the AWS SDK for C++ when we use the C++ KMS keyring. */
     Aws::SDKOptions options;
     Aws::InitAPI(options);
 

examples/string_alternate_algorithm_suite.cpp

@@ -219,7 +219,7 @@ int main(int argc, char **argv) {
         return ret;
     }
 
-    /* We need to intialize the AWS SDK for C++ when we use the C++ KMS keyring. */
+    /* We need to initialize the AWS SDK for C++ when we use the C++ KMS keyring. */
     Aws::SDKOptions options;
     Aws::InitAPI(options);
 

examples/string_legacy_compatibility.cpp

@@ -204,7 +204,7 @@ int main(int argc, char **argv) {
         return ret;
     }
 
-    /* We need to intialize the AWS SDK for C++ when we use the C++ KMS keyring. */
+    /* We need to initialize the AWS SDK for C++ when we use the C++ KMS keyring. */
     Aws::SDKOptions options;
     Aws::InitAPI(options);
 

include/aws/cryptosdk/error.h

@@ -62,7 +62,7 @@ enum aws_cryptosdk_err {
  * Implicitly registers error strings for aws-c-common as well.
  */
 AWS_CRYPTOSDK_API
-void aws_cryptosdk_load_error_strings();
+void aws_cryptosdk_load_error_strings(void);
 
 #ifdef __cplusplus
 }

source/cipher.c

@@ -470,7 +470,7 @@ static int evp_gcm_encrypt_final(const struct aws_cryptosdk_alg_properties *prop
     return AWS_ERROR_SUCCESS;
 }
 
-static inline void flush_openssl_errors() {
+static inline void flush_openssl_errors(void) {
     while (ERR_get_error() != 0) {
     }
 }

source/error.c

@@ -39,6 +39,6 @@ static const struct aws_error_info error_info[] = {
 static const struct aws_error_info_list error_info_list = { .error_list = error_info,
                                                             .count      = sizeof(error_info) / sizeof(error_info[0]) };
 
-void aws_cryptosdk_load_error_strings() {
+void aws_cryptosdk_load_error_strings(void) {
     aws_register_error_info(&error_info_list);
 }

tests/integration/t_local_cache_threading.c

@@ -81,8 +81,8 @@ struct rand_state {
 #define RNG_GENERATOR 16807
 #define RNG_MAX (RNG_MODULUS - 1)
 
-static unsigned long threadid_get_callback() {
-    return aws_thread_current_thread_id();
+static unsigned long threadid_get_callback(void) {
+    return (unsigned long)aws_thread_current_thread_id();
 }
 
 static struct aws_mutex *mutex_array = NULL;