Skip to content

loot: enforce minCount == maxCount for reference loot entries #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sudlud opened this issue Nov 25, 2024 · 0 comments
Open

loot: enforce minCount == maxCount for reference loot entries #3180

sudlud opened this issue Nov 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sudlud
Copy link
Member

sudlud commented Nov 25, 2024

Right now when editing loot, the minCount field is not beeing shown for reference loot entries because it is not supported by the core.
Keira will set it to default = 1 if I've seen it correctly. this leads to entries beeing added with minCount < maxCount.

I'd like to have Keira "enforce" that it's beeing set to the same value as maxCount because then it's clear to anyone looking at the loot templates that there's no variation for reference loot entries.

I'm also introducing a core side startup check for this right now so it would be nice to have Keira support anyone editing these :)

azerothcore/azerothcore-wotlk#20725

The goal is to avoid misconfiguring loot templates.

@Helias Helias added the enhancement New feature or request label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants